Change to add zoom animations to nanobench

Change to add zoom animations to nanobench

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/261c3ad7fde95748da92550735decc949dc73bf2

[joshualitt, 2015-04-24 21:08:29]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-04-24 21:08:30]

ptal

[joshualitt, 2015-04-24 21:55:39]

feedback inc

[bsalomon, 2015-04-27 14:31:43]

lgtm

https://codereview.chromium.org/1061323003/diff/20001/bench/SKPAnimationBench.h
File bench/SKPAnimationBench.h (right):

https://codereview.chromium.org/1061323003/diff/20001/bench/SKPAnimationBench...
bench/SKPAnimationBench.h:20: SkMatrix viewMatrix, int steps);
I'd call this "animationMatrix" rather than "viewMatrix"

https://codereview.chromium.org/1061323003/diff/20001/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1061323003/diff/20001/bench/nanobench.cpp#new...
bench/nanobench.cpp:86: DEFINE_string(zoom, "1.0,1.0,1", "Comma-separated
X,Y,Step zoom factors for SKPs.");
Do you think it really makes sense to have two scale factors? If we're going to
generalize beyond a single scale factor, I'd jump to a full matrix.

https://codereview.chromium.org/1061323003/diff/40001/bench/SKPAnimationBench.h
File bench/SKPAnimationBench.h (right):

https://codereview.chromium.org/1061323003/diff/40001/bench/SKPAnimationBench...
bench/SKPAnimationBench.h:28: SkFAIL("MPD not supported\n");
Won't this cause you to crash in a run that has the default mpd flag?

Maybe we should just go ahead and implement it.

[joshualitt, 2015-04-27 15:29:50]

https://codereview.chromium.org/1061323003/diff/40001/bench/SKPAnimationBench.h
File bench/SKPAnimationBench.h (right):

https://codereview.chromium.org/1061323003/diff/40001/bench/SKPAnimationBench...
bench/SKPAnimationBench.h:28: SkFAIL("MPD not supported\n");
On 2015/04/27 14:31:43, bsalomon wrote:
> Won't this cause you to crash in a run that has the default mpd flag?
> 
> Maybe we should just go ahead and implement it.

Its your call.  Its currently never called because I have hardcoded useMpd =
false in the call to construct the base class.

[joshualitt, 2015-04-27 15:31:17]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-04-27 15:31:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061323003/40001

[joshualitt, 2015-04-27 15:41:41]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2015-04-27 16:04:38]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-04-27 16:04:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1061323003/#ps60001
(title: "windows warning")

[commit-bot: I haz the power, 2015-04-27 16:04:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061323003/60001

[commit-bot: I haz the power, 2015-04-27 16:17:01]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/261c3ad7fde95748da92550735decc949dc73bf2