Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1061283002: Send SkPicture deletion message lazily. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Send SkPicture deletion message lazily. If no one has read the picture's unique ID, there's no point invalidating it. This is the same trick we pull with SkPixelRefs. Before: 26M 1 1.49µs 1.6µs 1.77µs 6.25µs 42% picture_overhead_draw 13M 32 742ns 749ns 756ns 823ns 2% picture_overhead_nodraw After: 26M 1 1.27µs 1.33µs 1.49µs 5.51µs 45% picture_overhead_draw 14M 43 677ns 680ns 681ns 701ns 1% picture_overhead_nodraw BUG=skia: Committed: https://skia.googlesource.com/skia/+/e35268ef4cdaa29600671cdf9d0ebb43b622d1a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M include/core/SkPicture.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPicture.cpp View 5 chunks +27 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein
5 years, 8 months ago (2015-04-07 11:58:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061283002/1
5 years, 8 months ago (2015-04-07 12:29:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 1061283002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-07 12:29:20 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061283002/1
5 years, 8 months ago (2015-04-07 13:17:53 UTC) #8
commit-bot: I haz the power
Presubmit check for 1061283002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-07 13:17:57 UTC) #10
reed1
The actual (lazy) computation for the uniqueID... is it capturable in a helper function or ...
5 years, 8 months ago (2015-04-07 13:19:31 UTC) #11
mtklein
On 2015/04/07 13:19:31, reed1 wrote: > The actual (lazy) computation for the uniqueID... is it ...
5 years, 8 months ago (2015-04-07 13:21:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061283002/1
5 years, 8 months ago (2015-04-07 13:21:43 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 13:34:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e35268ef4cdaa29600671cdf9d0ebb43b622d1a3

Powered by Google App Engine
This is Rietveld 408576698