Throw NoModificationAllowed in SVG*List.removeItem(...) if immutable

Throw NoModificationAllowed in SVG*List.removeItem(...) if immutable

BUG=477790
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194506

[fs, 2015-04-24 12:04:19]

fs@opera.com changed reviewers:
+ kouhei@chromium.org, pdr@chromium.org

[pdr., 2015-04-24 22:28:13]

LGTM

(Maybe for another patch) Would it be possible to make the getters const so this
is more obvious?

https://codereview.chromium.org/1061263005/diff/1/LayoutTests/svg/dom/svglist...
File LayoutTests/svg/dom/svglist-immutable.html (right):

https://codereview.chromium.org/1061263005/diff/1/LayoutTests/svg/dom/svglist...
LayoutTests/svg/dom/svglist-immutable.html:31: assert_equals(list.length, 2);
Indentation (here, elsewhere)

[fs, 2015-04-27 10:24:29]

On 2015/04/24 22:28:13, pdr wrote:
...
> (Maybe for another patch) Would it be possible to make the getters const so
this
> is more obvious?

Not sure if we'd be able to get that much out of that (most of the methods do
mutate things), but I suppose I could look at it.

https://codereview.chromium.org/1061263005/diff/1/LayoutTests/svg/dom/svglist...
File LayoutTests/svg/dom/svglist-immutable.html (right):

https://codereview.chromium.org/1061263005/diff/1/LayoutTests/svg/dom/svglist...
LayoutTests/svg/dom/svglist-immutable.html:31: assert_equals(list.length, 2);
On 2015/04/24 22:28:12, pdr wrote:
> Indentation (here, elsewhere)

Bah, fixed.

[fs, 2015-04-27 10:24:33]

The CQ bit was checked by fs@opera.com

[fs, 2015-04-27 10:24:33]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1061263005/#ps20001
(title: "Indentation.")

[commit-bot: I haz the power, 2015-04-27 10:24:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061263005/20001

[kouhei (in TOK), 2015-04-27 10:27:41]

lgtm

[commit-bot: I haz the power, 2015-04-27 10:28:15]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194506