bindings: Adds check for attributes on prototype chains in CSSStyleDeclaration.

Source/bindings/templates/interface_base.cpp

 {% include 'copyright_block.txt' %}
 #include "config.h"
 {% filter conditional(conditional_string) %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
@@ skipping 375 matching lines @@
            '%sV8Internal::namedPropertyQueryCallback' % cpp_class
            if named_property_getter.is_enumerable else '0' %}
     {% set named_property_deleter_callback =
            '%sV8Internal::namedPropertyDeleterCallback' % cpp_class
            if named_property_deleter else '0' %}
     {% set named_property_enumerator_callback =
            '%sV8Internal::namedPropertyEnumeratorCallback' % cpp_class
            if named_property_getter.is_enumerable else '0' %}
     {
         v8::NamedPropertyHandlerConfiguration config({{named_property_getter_callback}}, {{named_property_setter_callback}}, {{named_property_query_callback}}, {{named_property_deleter_callback}}, {{named_property_enumerator_callback}});
-        {% if not named_property_getter.is_custom %}
+        {% if interface_name != 'Window' %}

[dcarney, 2015/04/09 11:03:09]

i think there are nsobject callbacks which you will break here.  please use
interface_name == 'CSS...'

[bashi, 2015/04/10 00:15:32]

It would be a bit difficult to understand why we have this branch when we read
this later. Could we do either:
- add a comment
- introduce a variable with descriptive name
?

[Yuki, 2015/04/10 14:06:49]

For NPObject, we don't use any auto-generated binding code, all the
implementations are hand-written.  So I think this is okay.

And as you wrote, since we shouldn't use HasRealNamedProperty or
GetRealNamedPropertyInPrototypeChain, then not only CSSStyleDeclaration but also
other interfaces should use kNonMasking flag, I think.  Having said that,
Window's implementation is a little bit special, so I'd like to exclude Window
in this CL and will address Window's attributes separately.

         config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings));
         {% endif %}
         {% if named_property_getter.do_not_check_security %}
         config.flags = v8::PropertyHandlerFlags::kAllCanRead;
         {% endif %}
-        {% if not is_override_builtins and not named_property_getter.is_custom %}
+        {% if not is_override_builtins and interface_name != 'Window' %}
         config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kNonMasking));
         {% endif %}
         functionTemplate->{{set_on_template}}()->SetHandler(config);
     }
     {% endif %}
     {% if iterator_method %}
     {% filter per_context_enabled(iterator_method.per_context_enabled_function) %}
     {% filter exposed(iterator_method.exposed_test) %}
     {% filter runtime_enabled(iterator_method.runtime_enabled_function) %}
     static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{cpp_class_or_partial}}V8Internal::iteratorMethodCallback, 0, V8DOMConfiguration::ExposedToAllScripts };
@@ skipping 86 matching lines @@
 {% endfor %}
 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
 {{attribute_getter_implemented_in_private_script(attribute)}}
 {% if attribute.has_setter %}
 {{attribute_setter_implemented_in_private_script(attribute)}}
 {% endif %}
 {% endfor %}
 {% block partial_interface %}{% endblock %}
 } // namespace blink
 {% endfilter %}