cc: Remove invalidation history

cc: Remove invalidation history

Now that Blink handles animated gifs, this code is not needed.

BUG=467197
Committed: https://crrev.com/4b219b204e672f48ba743919342191a001a27b9b
Cr-Commit-Position: refs/heads/master@{#324084}

[enne (OOO), 2015-04-07 01:02:17]

enne@chromium.org changed reviewers:
+ vmpstr@chromium.org

[enne (OOO), 2015-04-07 01:03:50]

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_u...
File cc/resources/picture_pile_unittest.cc (left):

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_u...
cc/resources/picture_pile_unittest.cc:189: TEST_F(PicturePileTest,
InvalidateOnTileBoundaryInflated) {
I need to check if this is tested elsewhere, or if this just happens to use
invalidation frequency to test this path.

[vmpstr, 2015-04-07 17:43:15]

A bunch of nits below

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile.cc
File cc/resources/picture_pile.cc (right):

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile.c...
cc/resources/picture_pile.cc:253: has_any_recordings_ |= true;
nit: = true

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
File cc/resources/picture_pile_impl.cc (right):

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
cc/resources/picture_pile_impl.cc:139: if (!picture)
This can be removed

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
cc/resources/picture_pile_impl.cc:272: if (picture &&
pictures_seen.insert(picture).second)
"picture &&" can be removed, or DCHECKed

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
cc/resources/picture_pile_impl.cc:359: if (!map_iter->second.get())
This can also be removed?

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
cc/resources/picture_pile_impl.cc:385: if (picture &&
(appended_pictures.count(picture) == 0)) {
Here as well.

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
cc/resources/picture_pile_impl.cc:442: if (!picture ||
(processed_pictures_.count(picture) != 0) ||
Here as well.

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_i...
cc/resources/picture_pile_impl.cc:457: if (picture &&
(processed_pictures.count(picture) == 0)) {
Here as well.

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_u...
File cc/resources/picture_pile_unittest.cc (left):

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_u...
cc/resources/picture_pile_unittest.cc:189: TEST_F(PicturePileTest,
InvalidateOnTileBoundaryInflated) {
On 2015/04/07 01:03:50, enne wrote:
> I need to check if this is tested elsewhere, or if this just happens to use
> invalidation frequency to test this path.

Ya, we should retain these tests if possible.

[enne (OOO), 2015-04-07 17:59:43]

Thanks for pointing out all those extra cleanups.  Oops!  Fixed.

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_u...
File cc/resources/picture_pile_unittest.cc (left):

https://codereview.chromium.org/1061203002/diff/1/cc/resources/picture_pile_u...
cc/resources/picture_pile_unittest.cc:189: TEST_F(PicturePileTest,
InvalidateOnTileBoundaryInflated) {
On 2015/04/07 17:43:14, vmpstr wrote:
> On 2015/04/07 01:03:50, enne wrote:
> > I need to check if this is tested elsewhere, or if this just happens to use
> > invalidation frequency to test this path.
> 
> Ya, we should retain these tests if possible.

I think InvalidationOnTileBorderOutsideInterestRect covers the tests I want to
keep from here, with respect to border pixels and invalidations.

[vmpstr, 2015-04-07 18:10:58]

lgtm

[enne (OOO), 2015-04-07 18:19:33]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-04-07 18:20:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061203002/20001

[commit-bot: I haz the power, 2015-04-07 19:11:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 19:13:28]

Patchset 2 (id:??) landed as
https://crrev.com/4b219b204e672f48ba743919342191a001a27b9b
Cr-Commit-Position: refs/heads/master@{#324084}