[New Tab Page] Reset default parameters for NTP title.html, adding param for multiline.

[New Tab Page] Reset default parameters for NTP title.html, adding param for multiline.

http://crrev.com/1047223004 added experimental icon NTP support and
changed default "white-space: nowrap" to "white-space: pre-wrap", then
make current Material Design select the old one. This is broke 3rd-party
NTPs that don't have the same setting. This CL changes the defaults back,
and adds a new "ntl" to signal intent of having multiline titles. Also
updated single-iframe NTP to match.

BUG=474164
Committed: https://crrev.com/1826022c5cffbcc3cc44a6162b01236a2a952410
Cr-Commit-Position: refs/heads/master@{#324097}

[huangs, 2015-04-07 00:15:43]

huangs@chromium.org changed reviewers:
+ fserb@chromium.org, mathp@chromium.org

[huangs, 2015-04-07 03:36:33]

Oops forgot to send out. PTAL.

[Mathieu, 2015-04-07 13:28:00]

On 2015/04/07 03:36:33, huangs wrote:
> Oops forgot to send out. PTAL.

lgtm

[fserb, 2015-04-07 17:25:13]

https://codereview.chromium.org/1061163003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/local_ntp/most_visited_single.js (right):

https://codereview.chromium.org/1061163003/diff/20001/chrome/browser/resource...
chrome/browser/resources/local_ntp/most_visited_single.js:355: if
(NUM_TITLE_LINES > 1) {
How is this supposed to work?
It doesn't matter the number of tiles per line?

[huangs, 2015-04-07 17:28:22]

Responded.

https://codereview.chromium.org/1061163003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/local_ntp/most_visited_single.js (right):

https://codereview.chromium.org/1061163003/diff/20001/chrome/browser/resource...
chrome/browser/resources/local_ntp/most_visited_single.js:355: if
(NUM_TITLE_LINES > 1) {
It's number of lines per title.  Single line title can truncated.  Multi-line
would require wrap, and more complicated treatment at end (TODO).

[chromium-reviews, 2015-04-07 17:51:05]

But then, what does this do right now?

On Tue, Apr 7, 2015 at 1:28 PM <huangs@chromium.org> wrote:

> Responded.
>
>
> https://codereview.chromium.org/1061163003/diff/20001/chrome
> /browser/resources/local_ntp/most_visited_single.js
> File chrome/browser/resources/local_ntp/most_visited_single.js (right):
>
> https://codereview.chromium.org/1061163003/diff/20001/chrome
> /browser/resources/local_ntp/most_visited_single.js#newcode355
> chrome/browser/resources/local_ntp/most_visited_single.js:355
>
<https://codereview.chromium.org/1061163003/diff/20001/chrome/browser/resource...>:
> if
> (NUM_TITLE_LINES > 1) {
> It's number of lines per title.  Single line title can truncated.
> Multi-line would require wrap, and more complicated treatment at end
> (TODO).
>
> https://codereview.chromium.org/1061163003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[huangs, 2015-04-07 18:04:11]

The variable, if > 1, causes ".multiline" to be added to each title, which by
most_visited_single.css , causes line to break word and wrap.

[fserb, 2015-04-07 20:00:17]

On 2015/04/07 18:04:11, huangs wrote:
> The variable, if > 1, causes ".multiline" to be added to each title, which by
> most_visited_single.css , causes line to break word and wrap.

lgtm

[huangs, 2015-04-07 20:00:34]

The CQ bit was checked by huangs@chromium.org

[huangs, 2015-04-07 20:00:34]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1061163003/#ps20001
(title: "Adapting style to local file.")

[commit-bot: I haz the power, 2015-04-07 20:01:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061163003/20001

[commit-bot: I haz the power, 2015-04-07 20:06:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 20:07:33]

Patchset 2 (id:??) landed as
https://crrev.com/1826022c5cffbcc3cc44a6162b01236a2a952410
Cr-Commit-Position: refs/heads/master@{#324097}