Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: sky/tests/layout/document-elementFromPoint.sky

Issue 1061163002: Remove all uses of display:block and display:inline-block. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update one more usage Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tests/layout/document-elementFromPoint.sky
diff --git a/sky/tests/layout/document-elementFromPoint.sky b/sky/tests/layout/document-elementFromPoint.sky
index 94257d81cd6491aa7c4908810d9e4c94bd5fe675..eac408e357c458e94c3a9ea28052ea2198f514a5 100644
--- a/sky/tests/layout/document-elementFromPoint.sky
+++ b/sky/tests/layout/document-elementFromPoint.sky
@@ -5,15 +5,15 @@ bar { width: 100px; height: 100px; background: purple; }
parent { display: paragraph; }
child { background: salmon; }
canvas { height: 50px; background-color: pink; }
-inline-block { display: inline-block; width: 50px; height: 50px; background: green; }
+inline-flex { display: inline-flex; width: 50px; height: 50px; background: green; }
grand-child { width: 50px; height: 50px; transform: translate3d(100px, 0, 0); background: papayawhip; }
</style>
<foo /><bar />
<parent>
<child>Foo bar</child>
- <inline-block>
+ <inline-flex>
<grand-child />
- </inline-block>
+ </inline-flex>
</parent>
<canvas />
<script>
@@ -57,11 +57,11 @@ void main() {
});
test("should hit test transformed child", () {
- document.querySelector('parent').style["display"] = "block";
+ document.querySelector('parent').style["display"] = "flex";
document.querySelector('child').style["transform"] = "translate3d(100px, 0, 0)";
expect(document.elementFromPoint(50, 210).tagName, equals('parent'));
expect(document.elementFromPoint(150, 210).tagName, equals('child'));
- expect(document.elementFromPoint(25, 240).tagName, equals('inline-block'));
+ expect(document.elementFromPoint(25, 240).tagName, equals('inline-flex'));
// TODO(ojan): This is incorrect. It should hit grand-child.
// This broke sometime before 4153b8a515d54275934d4244aaf2d5a7a8fe3333.
expect(document.elementFromPoint(150, 240).tagName, equals('sky'));

Powered by Google App Engine
This is Rietveld 408576698