Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1061153002: Remove WebViewImpl preferred size hack (Closed)

Created:
5 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 8 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove WebViewImpl preferred size hack In r193218, we changed scrollWidth/Height to return rounded instead of truncated values, and I added a hack to WebViewImpl to maintain the old behavior and not conflate that change with the DOM api change. The old behavior is actually buggy and ends up with the viewport size sometimes being off by a few pixels when there's zooming. This patch removes the hack in WebViewImpl and updates WebViewTest to this new behavior. BUG=471336 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193401

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Use Flexbox to avoid whitespace issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M Source/web/WebViewImpl.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/web/tests/data/specify_size.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
leviw_travelin_and_unemployed
5 years, 8 months ago (2015-04-06 23:11:07 UTC) #2
pdr.
LGTM!
5 years, 8 months ago (2015-04-06 23:13:04 UTC) #3
not at google - send to devlin
Thanks Levi (my lgtm doesn't do anything).
5 years, 8 months ago (2015-04-06 23:38:33 UTC) #4
paulmeyer
On 2015/04/06 23:38:33, kalman wrote: > Thanks Levi (my lgtm doesn't do anything). Lgtm.
5 years, 8 months ago (2015-04-07 12:25:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061153002/20001
5 years, 8 months ago (2015-04-07 23:57:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50862)
5 years, 8 months ago (2015-04-08 01:06:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061153002/40001
5 years, 8 months ago (2015-04-08 22:10:54 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 00:15:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193401

Powered by Google App Engine
This is Rietveld 408576698