Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1061133005: Wait for 'after_install' from widget before closing SuggestAppsDialog (Closed)

Created:
5 years, 8 months ago by tbarzic
Modified:
5 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@break_up_suggest_apps_dialog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait for 'after_install' from widget before closing SuggestAppsDialog The widget design doc indicates that the widget can be closed after 'after_install' is received. This message was not previously handled by suggest apps dialog. BUG=439446 TEST=Installed file handler/file system provider from SuggestAppsDialog Committed: https://crrev.com/73accbabee734542f611896b06db4b7b57475a75 Cr-Commit-Position: refs/heads/master@{#325105}

Patch Set 1 #

Patch Set 2 : hide spinner on install failure #

Patch Set 3 : typos #

Patch Set 4 : . #

Patch Set 5 : fix test #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M chrome/test/data/chromeos/file_manager/cws_container_mock/main.js View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/app_installer.js View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/cws_container_client.js View 1 2 3 chunks +17 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/cws_widget_container.js View 1 2 6 chunks +36 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tbarzic
Built on top of https://codereview.chromium.org/1068653002/ (a little thing I noticed while working on that patch). ...
5 years, 8 months ago (2015-04-07 02:12:07 UTC) #2
yoshiki
lgtm. Thanks!
5 years, 8 months ago (2015-04-07 07:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061133005/60001
5 years, 8 months ago (2015-04-07 18:54:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/43804)
5 years, 8 months ago (2015-04-07 20:41:18 UTC) #8
tbarzic
fixed the failing test, PTAL
5 years, 8 months ago (2015-04-08 06:18:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061133005/100001
5 years, 8 months ago (2015-04-14 17:15:28 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-14 19:40:07 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 19:41:04 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/73accbabee734542f611896b06db4b7b57475a75
Cr-Commit-Position: refs/heads/master@{#325105}

Powered by Google App Engine
This is Rietveld 408576698