Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1061133004: Fix deadlock in ChildProcessService.onDestroy() (Closed)

Created:
5 years, 8 months ago by no sievers
Modified:
5 years, 8 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Fix deadlock in ChildProcessService.onDestroy() onCreate() spawns the CrMain thread. onDestroy() can happen quickly after onCreate() (for example if the browser crashes), so we have to be careful about blocking on any semaphores wrt the CrMain thread. The existing cmdline check did not cover all of that. In addition we have to avoid deadlocks between nativeShutdownMainThread()and us actually not having ever entered native main(). (ChildThreadImpl::Shutdown() on Android waits on a condition variable.) BUG=448549, 457406, 457914 NOTRY=True Review URL: https://codereview.chromium.org/1052133002 Cr-Commit-Position: refs/heads/master@{#323567} Committed: https://chromium.googlesource.com/chromium/src/+/4d95abadb6d081349c9d4e3ffb0036c575e92567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
no sievers
5 years, 8 months ago (2015-04-07 02:07:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d95abadb6d081349c9d4e3ffb0036c575e92567 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698