Attempted mitigation of font tables released early.

Attempted mitigation of font tables released early.

On Mac, it appears that sometimes fonts created from data have
their table data used after the table data copy is freed.
This appears to be most common with 'sbix' fonts for some reason,
so pin that table while in use.

Committed: https://skia.googlesource.com/skia/+/e3bea5cc609a82411edd98b0a3f0b542f65ba67e

[bungeman-skia, 2015-04-06 22:16:25]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2015-04-06 22:16:26]

This is a very low impact experiment to see if keeping our own reference to the
'sbix' table when it exists affects the crash rate of the associated bug (and if
it crashes somewhere else). If it does, then it at least informs somewhat as to
where things are going wrong. Note that this should be rather low impact, as
we're only calling to copy the table when the call to draw the glyphs will be
doing (almost) the same call anyway. Note that the CGFontCopyTableForTag usually
just copies a ref, it doesn't usually copy any actual data.

[bungeman-skia, 2015-04-06 22:45:26]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-04-06 22:45:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061123002/20001

[commit-bot: I haz the power, 2015-04-06 22:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-06 22:45:40]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bungeman-skia, 2015-04-06 22:55:49]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-06 22:55:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061123002/20001

[commit-bot: I haz the power, 2015-04-06 23:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-06 23:01:59]

This issue passed the CQ dry run.

[reed1, 2015-04-07 13:13:12]

lgtm

https://codereview.chromium.org/1061123002/diff/20001/src/ports/SkFontHost_ma...
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/1061123002/diff/20001/src/ports/SkFontHost_ma...
src/ports/SkFontHost_mac.cpp:456: ,
fHasColorGlyphs(CTFontGetSymbolicTraits(fFontRef) & SkCTFontColorGlyphsTrait)
SkToBool ?

[bungeman-skia, 2015-04-07 14:28:36]

https://codereview.chromium.org/1061123002/diff/20001/src/ports/SkFontHost_ma...
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/1061123002/diff/20001/src/ports/SkFontHost_ma...
src/ports/SkFontHost_mac.cpp:456: ,
fHasColorGlyphs(CTFontGetSymbolicTraits(fFontRef) & SkCTFontColorGlyphsTrait)
On 2015/04/07 13:13:12, reed1 wrote:
> SkToBool ?

Hmmmm... I just moved this line, but I suppose it wouldn't hurt. Done.

[bungeman-skia, 2015-04-07 14:28:44]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-04-07 14:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1061123002/#ps40001
(title: "Add SkToBool")

[commit-bot: I haz the power, 2015-04-07 14:28:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1061123002/40001

[commit-bot: I haz the power, 2015-04-07 14:34:42]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e3bea5cc609a82411edd98b0a3f0b542f65ba67e