Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1061103003: Revert of Fix docked browser window sometimes appears onscreen after restart (Closed)

Created:
5 years, 8 months ago by Sergey Ulanov
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix docked browser window sometimes appears onscreen after restart (patchset #1 id:1 of https://codereview.chromium.org/1055893003/) Reason for revert: Broke BrowserWindowCocoaTest.TestMinimizeState on 10.6: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/762 Original issue's description: > Change IsMaximized() to return false if the window is in the dock, and > a unit test to make sure this is always the case. It turns out > -isZoomed can sometimes return YES for a docked window, which > sometimes results in the window becoming undocked on the next restart. > Please read the long entry in the bug report for a complete explanation > of how the change fixes the problem. > > BUG=452976 > > Committed: https://crrev.com/de8b6d82a032a4bde620e43e6c580850871d59d8 > Cr-Commit-Position: refs/heads/master@{#323928} TBR=avi@chromium.org,shrike@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452976 Committed: https://crrev.com/4e87fae17607eabe7fd7afa4f5daec16d217c868 Cr-Commit-Position: refs/heads/master@{#323961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
Created Revert of Fix docked browser window sometimes appears onscreen after restart
5 years, 8 months ago (2015-04-06 22:18:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061103003/1
5 years, 8 months ago (2015-04-06 22:18:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 22:20:35 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 22:21:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e87fae17607eabe7fd7afa4f5daec16d217c868
Cr-Commit-Position: refs/heads/master@{#323961}

Powered by Google App Engine
This is Rietveld 408576698