Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1061063004: Revert of Don't keep recreating AXMenuListPopup (Closed)

Created:
5 years, 8 months ago by Stephen Chennney
Modified:
5 years, 8 months ago
CC:
blink-reviews, nektarios, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@suppress_extra_events
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Don't keep recreating AXMenuListPopup (patchset #8 id:140001 of https://codereview.chromium.org/1059503002/) Reason for revert: This appears to be blocking the Blink roll due to the failure of DumpAccessibilityTreeTest.AccessibilityModalDialogClosed See, for example, this attempted roll: https://codereview.chromium.org/1068753002/ Original issue's description: > Don't keep recreating AXMenuListPopup > > Every time an AXMenuList (corresponding to a > <select> element) needed to update its children, > we were recreating the AXMenuListPopup and > all of the AXMenuListOptions each time, which is > wasteful. This change avoids deleting the popup > and stores the options in AXObjectCache by > element, rather than by ID, so they can be reused > when the options are updated. > > BUG=323462 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193251 TBR=je_julie.kim@samsung.com,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=323462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -124 lines) Patch
D LayoutTests/accessibility/menu-list-popup-reuses-objects.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/accessibility/menu-list-popup-reuses-objects-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/modules/accessibility/AXMenuList.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXMenuList.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXMenuListOption.h View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/accessibility/AXMenuListOption.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/modules/accessibility/AXMenuListPopup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXMenuListPopup.cpp View 4 chunks +32 lines, -23 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 5 chunks +5 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen Chennney
Created Revert of Don't keep recreating AXMenuListPopup
5 years, 8 months ago (2015-04-07 17:54:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061063004/1
5 years, 8 months ago (2015-04-07 17:55:39 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 17:56:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193286

Powered by Google App Engine
This is Rietveld 408576698