Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1061063002: Reschedule redraw if hardware draw fails (Closed)

Created:
5 years, 8 months ago by boliu
Modified:
5 years, 8 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Reschedule redraw if hardware draw fails Direct change to branch 2311 since trunk has been massively refactored. Currently the only way hardware draw fails is during initial load before the first commit in the compositor. In this case, compositor SetNeedsBeginFrame to true throughout the load, but android webview gets into a livelock when both the corresponding onDraw and the fallback tick fail and skips rescheduling draws due to hardware draw failing. Fix by always rescheduling draws even if a draw fails. BUG=474167 R=hush@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/89781809d07f4936fe845429b098f888c3445353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
boliu
directly submitting change to release branch, since fix doesn't apply to trunk anymore
5 years, 8 months ago (2015-04-06 20:48:08 UTC) #2
hush (inactive)
These extra invalidates only happens during hardware initialization, which won't cause much performance hit I ...
5 years, 8 months ago (2015-04-06 23:30:28 UTC) #3
boliu
5 years, 8 months ago (2015-04-07 17:11:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
89781809d07f4936fe845429b098f888c3445353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698