chrome/common/partial_circular_buffer.h - Issue 1061053002: Fix PartialCircularBuffer OOB memcpy().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/partial_circular_buffer.h

Issue 1061053002: Fix PartialCircularBuffer OOB memcpy(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/partial_circular_buffer.h

diff --git a/chrome/common/partial_circular_buffer.h b/chrome/common/partial_circular_buffer.h

index 1f986ccc9bb48839fd8458588e2772f50635d825..e1fb118132061c15737f2b2e1a1d27570b12b142 100644

--- a/chrome/common/partial_circular_buffer.h

+++ b/chrome/common/partial_circular_buffer.h

@@ -52,7 +52,7 @@ class PartialCircularBuffer {

};

#pragma pack(pop)

- void DoWrite(void* dest, const void* src, uint32 num);

+ void DoWrite(const uint8* input, uint32 input_size);

// Used for reading and writing.

BufferData* buffer_data_;

« no previous file with comments | « no previous file | chrome/common/partial_circular_buffer.cc » ('j') | no next file with comments »