Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5134)

Unified Diff: chrome/common/partial_circular_buffer.h

Issue 1061053002: Fix PartialCircularBuffer OOB memcpy(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/partial_circular_buffer.cc » ('j') | chrome/common/partial_circular_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/partial_circular_buffer.h
diff --git a/chrome/common/partial_circular_buffer.h b/chrome/common/partial_circular_buffer.h
index 1f986ccc9bb48839fd8458588e2772f50635d825..1ba716383a1374172e6f2ac559543c5a7f110c7e 100644
--- a/chrome/common/partial_circular_buffer.h
+++ b/chrome/common/partial_circular_buffer.h
@@ -52,7 +52,7 @@ class PartialCircularBuffer {
};
#pragma pack(pop)
- void DoWrite(void* dest, const void* src, uint32 num);
+ uint32 DoWrite(const uint8* input, uint32 input_size);
Nico 2015/04/08 23:13:05 Document what this returns, mention that it can re
gzobqq 2015/04/09 08:36:40 I changed DoWrite() to handle the complete input i
// Used for reading and writing.
BufferData* buffer_data_;
« no previous file with comments | « no previous file | chrome/common/partial_circular_buffer.cc » ('j') | chrome/common/partial_circular_buffer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698