Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1060993005: Fix invalid call to Dart_NewSendPort with port id 0 in dart controller (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix invalid call to Dart_NewSendPort with port id 0 in dart controller BUG= R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7436c6de124ca20ac94f5f8db26f97f4ebe630bf

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M mojo/dart/embedder/mojo_natives.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 8 months ago (2015-04-06 21:17:13 UTC) #2
zra
lgtm
5 years, 8 months ago (2015-04-06 21:26:18 UTC) #3
Cutch
5 years, 8 months ago (2015-04-06 21:28:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7436c6de124ca20ac94f5f8db26f97f4ebe630bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698