Chromium Code Reviews| Index: chrome/browser/ui/webui/extensions/extension_settings_handler.h |
| diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.h b/chrome/browser/ui/webui/extensions/extension_settings_handler.h |
| index bf680e92d16b027b49eb8979552a62f9caf72b33..f2406d74a557fbc0acf7cc6f91a59703da9ec726 100644 |
| --- a/chrome/browser/ui/webui/extensions/extension_settings_handler.h |
| +++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.h |
| @@ -84,12 +84,6 @@ class ExtensionSettingsHandler |
| // Helper method that reloads all unpacked extensions. |
| void ReloadUnpackedExtensions(); |
| - // Callback for "requestExtensionsData" message. |
| - void HandleRequestExtensionsData(const base::ListValue* args); |
| - |
| - // Callback for "toggleDeveloperMode" message. |
| - void HandleToggleDeveloperMode(const base::ListValue* args); |
| - |
| // Callback for "launch" message. |
| void HandleLaunchMessage(const base::ListValue* args); |
| @@ -105,6 +99,9 @@ class ExtensionSettingsHandler |
| // Callback for the "showPath" message. |
| void HandleShowPath(const base::ListValue* args); |
| + // Callback for the "register" message. |
|
Dan Beam
2015/04/10 21:26:27
these are all actually "extensionSettings" prefixe
Devlin
2015/04/10 21:43:04
I would have thought so, too - was just matching t
|
| + void HandleRegisterMessage(const base::ListValue* args); |
| + |
| // Utility for callbacks that get an extension ID as the sole argument. |
| // Returns NULL if the extension isn't active. |
| const Extension* GetActiveExtension(const base::ListValue* args); |
| @@ -112,9 +109,6 @@ class ExtensionSettingsHandler |
| // Forces a UI update if appropriate after a notification is received. |
| void MaybeUpdateAfterNotification(); |
| - // Register for notifications that we need to reload the page. |
| - void MaybeRegisterForNotifications(); |
| - |
| // Called when the reinstallation is complete. |
| void OnReinstallComplete(bool success, |
| const std::string& error, |
| @@ -138,12 +132,6 @@ class ExtensionSettingsHandler |
| int deleting_rwh_id_; |
| int deleting_rph_id_; |
| - // We want to register for notifications only after we've responded at least |
| - // once to the page, otherwise we'd be calling JavaScript functions on objects |
| - // that don't exist yet when notifications come in. This variable makes sure |
| - // we do so only once. |
| - bool registered_for_notifications_; |
| - |
| content::NotificationRegistrar registrar_; |
| ScopedObserver<WarningService, WarningService::Observer> |