Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1060933003: [Android] Add an out-of-app instrumentation driver APK. (RELAND) (Closed)

Created:
5 years, 8 months ago by jbudorick
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, android-webview-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add an out-of-app instrumentation driver APK. (RELAND) BUG=444049 Committed: https://crrev.com/4d64d862917d9cd9e045e95c68a3dd984d4eabcd Cr-Commit-Position: refs/heads/master@{#327118}

Patch Set 1 : original (broke main Android builder) #

Patch Set 2 : revised: added @VisibleForTesting to ThreadUtils.postOnUiThreadDelayed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1093 lines, -92 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/javatests/AndroidManifest.xml View 2 chunks +3 lines, -1 line 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/ThreadUtils.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 3 chunks +5 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 9 chunks +78 lines, -15 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +30 lines, -11 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_helper.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_instrumentation_test_run.py View 2 chunks +28 lines, -3 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 5 chunks +11 lines, -3 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +3 lines, -1 line 0 comments Download
A testing/android/appurify_support.gyp View 1 chunk +22 lines, -0 lines 0 comments Download
A testing/android/appurify_support/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A testing/android/appurify_support/java/src/org/chromium/test/support/ResultsBundleGenerator.java View 1 chunk +30 lines, -0 lines 0 comments Download
A testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java View 1 chunk +56 lines, -0 lines 0 comments Download
A testing/android/broker/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A testing/android/broker/java/src/org/chromium/test/broker/OnDeviceInstrumentationBroker.java View 1 chunk +64 lines, -0 lines 0 comments Download
A testing/android/driver/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A testing/android/driver/java/AndroidManifest.xml View 1 chunk +23 lines, -0 lines 0 comments Download
A testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java View 1 chunk +271 lines, -0 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 6 chunks +11 lines, -56 lines 0 comments Download
A testing/android/on_device_instrumentation.gyp View 1 chunk +79 lines, -0 lines 0 comments Download
A testing/android/reporter/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusListener.java View 1 chunk +78 lines, -0 lines 0 comments Download
A testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java View 1 chunk +128 lines, -0 lines 0 comments Download
A testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReporter.java View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbudorick
This is a reland of https://codereview.chromium.org/1034053002/ patchset 1 is the original version patchset 2 is ...
5 years, 7 months ago (2015-04-27 16:20:45 UTC) #2
Yaron
On 2015/04/27 16:20:45, jbudorick wrote: > This is a reland of https://codereview.chromium.org/1034053002/ > > patchset ...
5 years, 7 months ago (2015-04-27 16:35:33 UTC) #3
cjhopman
lgtm
5 years, 7 months ago (2015-04-27 16:40:01 UTC) #4
Torne
android_webview LGTM
5 years, 7 months ago (2015-04-27 16:57:04 UTC) #5
Lei Zhang
lgtm for base/ build files and chrome/ since they are all unchanged from the last ...
5 years, 7 months ago (2015-04-27 20:13:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060933003/20001
5 years, 7 months ago (2015-04-27 20:31:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-27 21:14:11 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:15:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d64d862917d9cd9e045e95c68a3dd984d4eabcd
Cr-Commit-Position: refs/heads/master@{#327118}

Powered by Google App Engine
This is Rietveld 408576698