Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1060913004: Revert of Split spoken feedback up on a per format rule basis. (Closed)

Created:
5 years, 8 months ago by maniscalco
Modified:
5 years, 8 months ago
CC:
chromium-reviews, je_julie(Not used), oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split spoken feedback up on a per format rule basis. (patchset #20 id:440001 of https://codereview.chromium.org/1035983003/) Reason for revert: Looks like this is causing test timeouts on linux asan. For details, see https://code.google.com/p/chromium/issues/detail?id=477492 Original issue's description: > Split spoken feedback up on a per format rule basis. > > Committed: https://crrev.com/245c79e93e9c0ae0261e441537ecc35c78fcb134 > Cr-Commit-Position: refs/heads/master@{#325301} TBR=plundblad@chromium.org,dmazzoni@chromium.org,dtseng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d7daf38c8484b8e57151832ca78e494c7a5c1e97 Cr-Commit-Position: refs/heads/master@{#325335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -299 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 8 chunks +24 lines, -49 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 28 chunks +131 lines, -186 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +9 lines, -55 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Created Revert of Split spoken feedback up on a per format rule basis.
5 years, 8 months ago (2015-04-15 23:09:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060913004/1
5 years, 8 months ago (2015-04-15 23:09:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 23:11:14 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 23:12:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7daf38c8484b8e57151832ca78e494c7a5c1e97
Cr-Commit-Position: refs/heads/master@{#325335}

Powered by Google App Engine
This is Rietveld 408576698