[strong] Implement static restrictions on binding 'undefined' in arrow functions

[strong] Implement static restrictions on binding 'undefined' in arrow functions

Implements the strong mode proposal's static restrictions on the use of the
identifier 'undefined', for arrow functions. Assumes these restrictions are
intended to be identical to the restrictions on the use of 'eval and 'arguments'
in strict mode. In addition, Location variables inconsistantly named (e.g.
dupe_error_loc vs dupe_loc) are now consistently named the shorter way.

Baseline: https://codereview.chromium.org/1070633002

BUG=v8:3956
LOG=N

Committed: https://crrev.com/3d5717a71bdc19c584c277edce9f75a06e95895f
Cr-Commit-Position: refs/heads/master@{#27756}

[conradw, 2015-04-10 12:22:29]

Patchset #2 (id:20001) has been deleted

[conradw, 2015-04-10 12:27:01]

conradw@chromium.org changed reviewers:
+ rossberg@chromium.org

[conradw, 2015-04-10 12:27:13]

On 2015/04/10 12:27:01, conradw wrote:
> mailto:conradw@chromium.org changed reviewers:
> + mailto:rossberg@chromium.org

PTAL

[conradw, 2015-04-10 12:27:45]

https://codereview.chromium.org/1060883004/diff/40001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1060883004/diff/40001/src/preparser.h#newcode...
src/preparser.h:3067: // Workaround for preparser not keeping track of
positions.
Here's how the position of the error can be reported without the preparser
knowing where the identifier is...

[conradw, 2015-04-10 13:12:53]

Patchset #3 (id:60001) has been deleted

[conradw, 2015-04-10 13:57:05]

Patchset #4 (id:100001) has been deleted

[conradw, 2015-04-10 13:57:55]

Patchset #4 (id:120001) has been deleted

[conradw, 2015-04-10 13:59:37]

Patchset #4 (id:140001) has been deleted

[conradw, 2015-04-10 14:02:20]

Patchset #4 (id:160001) has been deleted

[rossberg, 2015-04-10 14:02:56]

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h
File src/preparser.h (left):

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#oldcode169
src/preparser.h:169: 
Accidental line deletion?

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#oldcode...
src/preparser.h:3012: 
Accidental line deletion?

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#newcode808
src/preparser.h:808: if (op == Token::COMMA && !left.is_parenthesized() &&
Nit: use ?: to avoid the imperative var initialisation.

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#newcode916
src/preparser.h:916: bool IsValidArrowParamList(Scope* scope, Scanner::Location*
undefined_loc)
Is the scope parameter used at all?

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#newcode...
src/preparser.h:1006: V8_INLINE ValidArrowParam IsValidArrowParams() const {
A function named Is* is expected to return a bool, so perhaps rename this to
ValidateArrowParams.

https://codereview.chromium.org/1060883004/diff/80001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1060883004/diff/80001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:5881: TEST(StrongArrow) {
Nit: rename to StrongUndefinedArrow

https://codereview.chromium.org/1060883004/diff/80001/test/mjsunit/strong/und...
File test/mjsunit/strong/undefined-arrow.js (right):

https://codereview.chromium.org/1060883004/diff/80001/test/mjsunit/strong/und...
test/mjsunit/strong/undefined-arrow.js:1: // Copyright 2014 the V8 project
authors. All rights reserved.
Nit: I'd prefer to keep these tests in the main file.

[conradw, 2015-04-10 14:03:32]

Patchset #4 (id:30010) has been deleted

[conradw, 2015-04-10 14:19:10]

Patchset #5 (id:200001) has been deleted

[conradw, 2015-04-10 14:20:49]

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h
File src/preparser.h (left):

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#oldcode169
src/preparser.h:169: 
On 2015/04/10 14:02:56, rossberg wrote:
> Accidental line deletion?

Done.

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#oldcode...
src/preparser.h:3012: 
On 2015/04/10 14:02:56, rossberg wrote:
> Accidental line deletion?

Done.

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#newcode808
src/preparser.h:808: if (op == Token::COMMA && !left.is_parenthesized() &&
On 2015/04/10 14:02:56, rossberg wrote:
> Nit: use ?: to avoid the imperative var initialisation.

Done.

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#newcode916
src/preparser.h:916: bool IsValidArrowParamList(Scope* scope, Scanner::Location*
undefined_loc)
On 2015/04/10 14:02:56, rossberg wrote:
> Is the scope parameter used at all?

Done.

https://codereview.chromium.org/1060883004/diff/80001/src/preparser.h#newcode...
src/preparser.h:1006: V8_INLINE ValidArrowParam IsValidArrowParams() const {
On 2015/04/10 14:02:56, rossberg wrote:
> A function named Is* is expected to return a bool, so perhaps rename this to
> ValidateArrowParams.

Done.

https://codereview.chromium.org/1060883004/diff/80001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1060883004/diff/80001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:5881: TEST(StrongArrow) {
On 2015/04/10 14:02:56, rossberg wrote:
> Nit: rename to StrongUndefinedArrow

Done.

https://codereview.chromium.org/1060883004/diff/80001/test/mjsunit/strong/und...
File test/mjsunit/strong/undefined-arrow.js (right):

https://codereview.chromium.org/1060883004/diff/80001/test/mjsunit/strong/und...
test/mjsunit/strong/undefined-arrow.js:1: // Copyright 2014 the V8 project
authors. All rights reserved.
On 2015/04/10 14:02:56, rossberg wrote:
> Nit: I'd prefer to keep these tests in the main file.

Done.

[rossberg, 2015-04-10 15:58:02]

lgtm

https://codereview.chromium.org/1060883004/diff/220001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1060883004/diff/220001/src/preparser.h#newcod...
src/preparser.h:915: const {
Nit: get rid of line break

[conradw, 2015-04-10 16:02:12]

https://codereview.chromium.org/1060883004/diff/220001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1060883004/diff/220001/src/preparser.h#newcod...
src/preparser.h:915: const {
On 2015/04/10 15:58:02, rossberg wrote:
> Nit: get rid of line break

Done.

[conradw, 2015-04-10 16:02:16]

The CQ bit was checked by conradw@chromium.org

[conradw, 2015-04-10 16:02:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1060883004/#ps240001
(title: "linebreak")

[commit-bot: I haz the power, 2015-04-10 16:02:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060883004/240001

[commit-bot: I haz the power, 2015-04-10 18:27:11]

Committed patchset #6 (id:240001)

[commit-bot: I haz the power, 2015-04-10 18:27:18]

Patchset 6 (id:??) landed as
https://crrev.com/3d5717a71bdc19c584c277edce9f75a06e95895f
Cr-Commit-Position: refs/heads/master@{#27756}