net/http/http_proxy_client_socket_pool.h - Issue 1060883002: Remove the confusing request_url argument from the constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool.h

Issue 1060883002: Remove the confusing request_url argument from the constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_proxy_client_socket_pool.h

diff --git a/net/http/http_proxy_client_socket_pool.h b/net/http/http_proxy_client_socket_pool.h

index 824b15f5becab9d3a049533804b3987c08811968..a0450fbe494dcaa0ef16d198237f16bdf82ce7a4 100644

--- a/net/http/http_proxy_client_socket_pool.h

+++ b/net/http/http_proxy_client_socket_pool.h

@@ -44,7 +44,6 @@ class NET_EXPORT_PRIVATE HttpProxySocketParams

HttpProxySocketParams(

const scoped_refptr<TransportSocketParams>& transport_params,

const scoped_refptr<SSLSocketParams>& ssl_params,

- const GURL& request_url,

const std::string& user_agent,

const HostPortPair& endpoint,

HttpAuthCache* http_auth_cache,

@@ -59,7 +58,6 @@ class NET_EXPORT_PRIVATE HttpProxySocketParams

const scoped_refptr<SSLSocketParams>& ssl_params() const {

return ssl_params_;

}

- const GURL& request_url() const { return request_url_; }

const std::string& user_agent() const { return user_agent_; }

const HostPortPair& endpoint() const { return endpoint_; }

HttpAuthCache* http_auth_cache() const { return http_auth_cache_; }

@@ -84,7 +82,6 @@ class NET_EXPORT_PRIVATE HttpProxySocketParams

const scoped_refptr<TransportSocketParams> transport_params_;

const scoped_refptr<SSLSocketParams> ssl_params_;

SpdySessionPool* spdy_session_pool_;

- const GURL request_url_;

const std::string user_agent_;

const HostPortPair endpoint_;

HttpAuthCache* const http_auth_cache_;

« net/http/http_proxy_client_socket.cc ('K') | « net/http/http_proxy_client_socket.cc ('k') | net/http/http_proxy_client_socket_pool.cc » ('j') | no next file with comments »