Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 1060883002: Remove the confusing request_url argument from the constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 socks_socket_params_( 102 socks_socket_params_(
103 new SOCKSSocketParams(proxy_transport_socket_params_, 103 new SOCKSSocketParams(proxy_transport_socket_params_,
104 true, 104 true,
105 HostPortPair("sockshost", 443))), 105 HostPortPair("sockshost", 443))),
106 socks_socket_pool_(kMaxSockets, 106 socks_socket_pool_(kMaxSockets,
107 kMaxSocketsPerGroup, 107 kMaxSocketsPerGroup,
108 &transport_socket_pool_), 108 &transport_socket_pool_),
109 http_proxy_socket_params_( 109 http_proxy_socket_params_(
110 new HttpProxySocketParams(proxy_transport_socket_params_, 110 new HttpProxySocketParams(proxy_transport_socket_params_,
111 NULL, 111 NULL,
112 GURL("http://host"),
113 std::string(), 112 std::string(),
114 HostPortPair("host", 80), 113 HostPortPair("host", 80),
115 session_->http_auth_cache(), 114 session_->http_auth_cache(),
116 session_->http_auth_handler_factory(), 115 session_->http_auth_handler_factory(),
117 session_->spdy_session_pool(), 116 session_->spdy_session_pool(),
118 true, 117 true,
119 NULL)), 118 NULL)),
120 http_proxy_socket_pool_(kMaxSockets, 119 http_proxy_socket_pool_(kMaxSockets,
121 kMaxSocketsPerGroup, 120 kMaxSocketsPerGroup,
122 &transport_socket_pool_, 121 &transport_socket_pool_,
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
913 ssl.channel_id_sent = true; 912 ssl.channel_id_sent = true;
914 ssl.SetNextProto(GetParam()); 913 ssl.SetNextProto(GetParam());
915 TestIPPoolingDisabled(&ssl); 914 TestIPPoolingDisabled(&ssl);
916 } 915 }
917 916
918 // It would be nice to also test the timeouts in SSLClientSocketPool. 917 // It would be nice to also test the timeouts in SSLClientSocketPool.
919 918
920 } // namespace 919 } // namespace
921 920
922 } // namespace net 921 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698