Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: net/http/http_proxy_client_socket.h

Issue 1060883002: Remove the confusing request_url argument from the constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_PROXY_CLIENT_SOCKET_H_ 5 #ifndef NET_HTTP_HTTP_PROXY_CLIENT_SOCKET_H_
6 #define NET_HTTP_HTTP_PROXY_CLIENT_SOCKET_H_ 6 #define NET_HTTP_HTTP_PROXY_CLIENT_SOCKET_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "net/base/completion_callback.h" 12 #include "net/base/completion_callback.h"
13 #include "net/base/host_port_pair.h" 13 #include "net/base/host_port_pair.h"
14 #include "net/base/load_timing_info.h" 14 #include "net/base/load_timing_info.h"
15 #include "net/http/http_auth_controller.h" 15 #include "net/http/http_auth_controller.h"
16 #include "net/http/http_request_headers.h" 16 #include "net/http/http_request_headers.h"
17 #include "net/http/http_request_info.h" 17 #include "net/http/http_request_info.h"
18 #include "net/http/http_response_info.h" 18 #include "net/http/http_response_info.h"
19 #include "net/http/proxy_client_socket.h" 19 #include "net/http/proxy_client_socket.h"
20 #include "net/log/net_log.h" 20 #include "net/log/net_log.h"
21 #include "net/socket/ssl_client_socket.h" 21 #include "net/socket/ssl_client_socket.h"
22 22
23 class GURL;
24
25 namespace net { 23 namespace net {
26 24
27 class AddressList; 25 class AddressList;
28 class ClientSocketHandle; 26 class ClientSocketHandle;
29 class GrowableIOBuffer; 27 class GrowableIOBuffer;
30 class HttpAuthCache; 28 class HttpAuthCache;
31 class HttpStream; 29 class HttpStream;
32 class HttpStreamParser; 30 class HttpStreamParser;
33 class IOBuffer; 31 class IOBuffer;
34 class ProxyDelegate; 32 class ProxyDelegate;
35 33
36 class HttpProxyClientSocket : public ProxyClientSocket { 34 class HttpProxyClientSocket : public ProxyClientSocket {
37 public: 35 public:
38 // Takes ownership of |transport_socket|, which should already be connected 36 // Takes ownership of |transport_socket|, which should already be connected
39 // by the time Connect() is called. If tunnel is true then on Connect() 37 // by the time Connect() is called. If tunnel is true then on Connect()
40 // this socket will establish an Http tunnel. 38 // this socket will establish an Http tunnel.
41 HttpProxyClientSocket(ClientSocketHandle* transport_socket, 39 HttpProxyClientSocket(ClientSocketHandle* transport_socket,
42 const GURL& request_url,
43 const std::string& user_agent, 40 const std::string& user_agent,
44 const HostPortPair& endpoint, 41 const HostPortPair& endpoint,
45 const HostPortPair& proxy_server, 42 const HostPortPair& proxy_server,
46 HttpAuthCache* http_auth_cache, 43 HttpAuthCache* http_auth_cache,
47 HttpAuthHandlerFactory* http_auth_handler_factory, 44 HttpAuthHandlerFactory* http_auth_handler_factory,
48 bool tunnel, 45 bool tunnel,
49 bool using_spdy, 46 bool using_spdy,
50 NextProto protocol_negotiated, 47 NextProto protocol_negotiated,
51 ProxyDelegate* proxy_delegate, 48 ProxyDelegate* proxy_delegate,
52 bool is_https_proxy); 49 bool is_https_proxy);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 ProxyDelegate* proxy_delegate_; 167 ProxyDelegate* proxy_delegate_;
171 168
172 const BoundNetLog net_log_; 169 const BoundNetLog net_log_;
173 170
174 DISALLOW_COPY_AND_ASSIGN(HttpProxyClientSocket); 171 DISALLOW_COPY_AND_ASSIGN(HttpProxyClientSocket);
175 }; 172 };
176 173
177 } // namespace net 174 } // namespace net
178 175
179 #endif // NET_HTTP_HTTP_PROXY_CLIENT_SOCKET_H_ 176 #endif // NET_HTTP_HTTP_PROXY_CLIENT_SOCKET_H_
OLDNEW
« no previous file with comments | « no previous file | net/http/http_proxy_client_socket.cc » ('j') | net/http/http_proxy_client_socket.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698