Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 106083005: Fix type error, add tests for it, get package ready for a patch release. (Closed)

Created:
7 years ago by Siggi Cherem (dart-lang)
Modified:
7 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type error, add tests for it, get package ready for a patch release. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=31174

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/build/runner.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/test/build/static_clean_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
7 years ago (2013-12-16 20:58:33 UTC) #1
Jennifer Messerly
lgtm
7 years ago (2013-12-16 21:03:23 UTC) #2
Siggi Cherem (dart-lang)
7 years ago (2013-12-16 21:03:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698