Source/modules/storage/DOMWindowStorageController.cpp - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/storage/DOMWindowStorageController.cpp

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: DOMWindowStorageController.h should include Document.h Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/speech/SpeechRecognitionController.h ('K') | « Source/modules/storage/DOMWindowStorageController.h ('k') | Source/modules/storage/StorageNamespaceController.h » ('j') | Source/modules/storage/StorageNamespaceController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/storage/DOMWindowStorageController.cpp

diff --git a/Source/modules/storage/DOMWindowStorageController.cpp b/Source/modules/storage/DOMWindowStorageController.cpp

index ca6023ad6156c44fa61f92fe0999c6f125c2b94e..8097370911e5ae7b15897b41587f407be5409008 100644

--- a/Source/modules/storage/DOMWindowStorageController.cpp

+++ b/Source/modules/storage/DOMWindowStorageController.cpp

@@ -42,7 +42,7 @@ DOMWindowStorageController& DOMWindowStorageController::from(Document& document)

DOMWindowStorageController* controller = static_cast<DOMWindowStorageController*>(WillBeHeapSupplement<Document>::from(document, supplementName()));

if (!controller) {

controller = new DOMWindowStorageController(document);

- DocumentSupplement::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));

+ WillBeHeapSupplement<Document>::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));

}

return *controller;

}