Source/modules/device_orientation/DeviceOrientationController.h - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationController.h

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: DOMWindowStorageController.h should include Document.h Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/page/Page.cpp ('K') | « Source/modules/device_orientation/DeviceMotionController.cpp ('k') | Source/modules/device_orientation/DeviceOrientationController.cpp » ('j') | Source/modules/encryptedmedia/MediaKeysController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationController.h

diff --git a/Source/modules/device_orientation/DeviceOrientationController.h b/Source/modules/device_orientation/DeviceOrientationController.h

index a2614f18b945d673e54539740842d9635edf1762..d3c800acaabf939c47a5e14d574434fec4ebd603 100644

--- a/Source/modules/device_orientation/DeviceOrientationController.h

+++ b/Source/modules/device_orientation/DeviceOrientationController.h

@@ -5,7 +5,7 @@

#ifndef DeviceOrientationController_h

#define DeviceOrientationController_h

-#include "core/dom/DocumentSupplementable.h"

+#include "core/dom/Document.h"

#include "core/frame/DeviceSingleWindowEventController.h"

#include "modules/ModulesExport.h"

@@ -14,7 +14,7 @@ namespace blink {

class DeviceOrientationData;

class Event;

-class MODULES_EXPORT DeviceOrientationController final : public DeviceSingleWindowEventController, public DocumentSupplement {

+class MODULES_EXPORT DeviceOrientationController final : public DeviceSingleWindowEventController, public WillBeHeapSupplement<Document> {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DeviceOrientationController);

public:

virtual ~DeviceOrientationController();