Source/core/html/imports/HTMLImportsController.h - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/imports/HTMLImportsController.h

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: DOMWindowStorageController.h should include Document.h Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/imports/HTMLImportsController.h

diff --git a/Source/core/html/imports/HTMLImportsController.h b/Source/core/html/imports/HTMLImportsController.h

index 3b902984dbbd67ef96a4f92bb8d2553ea7ce33e8..3d56f1367bef5ae1ad3fbda897d5c43f857d2905 100644

--- a/Source/core/html/imports/HTMLImportsController.h

+++ b/Source/core/html/imports/HTMLImportsController.h

@@ -31,7 +31,7 @@

#ifndef HTMLImportsController_h

#define HTMLImportsController_h

-#include "core/dom/DocumentSupplementable.h"

+#include "core/dom/Document.h"

#include "platform/heap/Handle.h"

#include "wtf/FastAllocBase.h"

#include "wtf/Vector.h"

@@ -46,7 +46,7 @@ class HTMLImportLoader;

class HTMLImportTreeRoot;

class KURL;

-class HTMLImportsController final : public NoBaseWillBeGarbageCollectedFinalized<HTMLImportsController>, public DocumentSupplement {

+class HTMLImportsController final : public NoBaseWillBeGarbageCollectedFinalized<HTMLImportsController>, public WillBeHeapSupplement<Document> {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLImportsController);

WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(HTMLImportsController);

public:

« no previous file with comments | « Source/core/dom/Fullscreen.cpp ('k') | Source/core/html/imports/HTMLImportsController.cpp » ('j') | Source/core/page/Page.cpp » ('J')