Source/platform/Supplementable.h - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/Supplementable.h

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webdatabase/DatabaseClient.h ('K') | « Source/modules/webdatabase/DatabaseClient.h ('k') | Source/platform/Supplementable.cpp » ('j') | Source/platform/Supplementable.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/Supplementable.h

diff --git a/Source/platform/Supplementable.h b/Source/platform/Supplementable.h

index 1f36b882bc660e7149cb6e98911b4c5cd62bc4eb..49c3fc9ae058ed86ad7a1d8f3312d17c0fa896ec 100644

--- a/Source/platform/Supplementable.h

+++ b/Source/platform/Supplementable.h

@@ -26,6 +26,7 @@

#ifndef Supplementable_h

#define Supplementable_h

+#include "platform/PlatformExport.h"

#include "platform/heap/Handle.h"

#include "wtf/Assertions.h"

#include "wtf/HashMap.h"

@@ -115,7 +116,7 @@ template<>

class SupplementTracing<true> : public GarbageCollectedMixin { };

template<>

-class GC_PLUGIN_IGNORE("crbug.com/476419") SupplementTracing<false> {

+class GC_PLUGIN_IGNORE("crbug.com/476419") PLATFORM_EXPORT SupplementTracing<false> {

tasak 2015/04/22 03:14:48 To fix SupplementTracing<0>::~SupplementTracing<0>

public:

virtual ~SupplementTracing() { }

// FIXME: Oilpan: this trace() method is only provided to minimize

« Source/modules/webdatabase/DatabaseClient.h ('K') | « Source/modules/webdatabase/DatabaseClient.h ('k') | Source/platform/Supplementable.cpp » ('j') | Source/platform/Supplementable.cpp » ('J')