Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: Source/platform/Supplementable.cpp

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/Supplementable.h ('k') | Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/Supplementable.cpp
diff --git a/Source/platform/Supplementable.cpp b/Source/platform/Supplementable.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..19b371a9a15487b562dbfe1a6724511acc706fa4
--- /dev/null
+++ b/Source/platform/Supplementable.cpp
@@ -0,0 +1,14 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "platform/Supplementable.h"
+
+// This Supplementable.cpp, which includes only config.h and
+// Supplementable.h, should be in Source/platform,
+// because Supplementable is not compiled without this cpp.
+// So if we don't have this cpp, we will see unresolved symbol error
+// when constructor/destructor's address is required.
+// i.e. error LNK2005: "public: virtual __cdecl
+// blink::SupplementTracing<0>::~SupplementTracing<0>(void)"
« no previous file with comments | « Source/platform/Supplementable.h ('k') | Source/platform/blink_platform.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698