Source/modules/device_orientation/DeviceMotionController.cpp - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceMotionController.cpp

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceMotionController.h ('k') | Source/modules/device_orientation/DeviceOrientationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceMotionController.cpp

diff --git a/Source/modules/device_orientation/DeviceMotionController.cpp b/Source/modules/device_orientation/DeviceMotionController.cpp

index 7701d9cba75030210f5f3ac467045e16471ed5fb..d08247d32eb3e3b84e5882686623e27991e5215e 100644

--- a/Source/modules/device_orientation/DeviceMotionController.cpp

+++ b/Source/modules/device_orientation/DeviceMotionController.cpp

@@ -36,10 +36,10 @@ const char* DeviceMotionController::supplementName()

DeviceMotionController& DeviceMotionController::from(Document& document)

{

- DeviceMotionController* controller = static_cast<DeviceMotionController*>(DocumentSupplement::from(document, supplementName()));

+ DeviceMotionController* controller = static_cast<DeviceMotionController*>(WillBeHeapSupplement<Document>::from(document, supplementName()));

if (!controller) {

controller = new DeviceMotionController(document);

- DocumentSupplement::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));

+ WillBeHeapSupplement<Document>::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));

}

return *controller;

}

@@ -100,7 +100,7 @@ const AtomicString& DeviceMotionController::eventTypeName() const

DEFINE_TRACE(DeviceMotionController)

{

DeviceSingleWindowEventController::trace(visitor);

- DocumentSupplement::trace(visitor);

+ WillBeHeapSupplement<Document>::trace(visitor);

}

} // namespace blink