Source/platform/Supplementable.cpp - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/Supplementable.cpp

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "platform/Supplementable.h"

	7

	8 // This Supplementable.cpp, which includes only config.h and

	9 // Supplementable.h, should be in Source/platform,

	10 // because Supplementable is not compiled without this cpp.

	11 // So if we don't have this cpp, we will see unresolved symbol error

	12 // when constructor/destructor's address is required.

	13 // i.e. error LNK2005: "public: virtual __cdecl

	14 // blink::SupplementTracing<0>::~SupplementTracing<0>(void)"
	tasak 2015/04/22 03:14:48 To compile Supplementable.h, need this cpp file. W To compile Supplementable.h, need this cpp file. Without this cpp file, MSVC does not compile Supplementable.h with "class __declspec(dllexport) SupplementTracing<false>".
OLD	NEW

« Source/platform/Supplementable.h ('K') | « Source/platform/Supplementable.h ('k') | Source/platform/blink_platform.gypi » ('j') | no next file with comments »