Source/core/page/PageSupplementable.h - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/page/PageSupplementable.h

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PageSupplementable_h

	6 #define PageSupplementable_h

	7

	8 #include "core/CoreExport.h"

	9 #include "platform/Supplementable.h"

	10

	11 namespace blink {

	12

	13 class Page;

	14

	15 extern template class CORE_TEMPLATE_EXPORT HeapSupplement<Page>;
	tasak 2015/04/22 03:14:48 Since both HeapSupplement<Page> and Supplement<Pag Since both HeapSupplement<Page> and Supplement<Page> are used, need to add the extern templates here (instead of 'extern template class CORE_TEMPLATE_EXPORT WillBeHeapSupplement<Page>').
	16 extern template class CORE_TEMPLATE_EXPORT Supplement<Page>;
	tasak 2015/04/22 03:14:48 To fix the following link errors: modules.dll.lib( To fix the following link errors: modules.dll.lib(modules.dll) : error LNK2005: "public: __cdecl blink::Supplement<class blink::Page>::Supplement<class blink::Page>(void)" (??0?$Supplement@VPage@blink@@@blink@@QEAA@XZ) already defined in blink_web.StorageQuotaClientImpl.obj modules.dll.lib(modules.dll) : error LNK2005: "public: virtual __cdecl blink::Supplement<class blink::Page>::~Supplement<class blink::Page>(void)" (??1?$Supplement@VPage@blink@@@blink@@UEAA@XZ) already defined in blink_web.DatabaseClientImpl.obj we should make core (not modules) to own Supplement<class blink::Page> (and also HeapSupplement<class blink::Page>). So we should explicitly say "extern template class __declspec(dllimport) Supplement<Page>" for modules / web. For core, "extern template class Supplement<Page>". Page.cpp instantiates the class, i.e. template class Supplement<Page>.
	17

	18 } // namespace blink

	19

	20 #endif // PageSupplementable_h

OLD	NEW

« Source/core/dom/DocumentSupplementable.h ('K') | « Source/core/page/Page.cpp ('k') | Source/core/testing/InternalSettings.h » ('j') | Source/modules/vibration/NavigatorVibration.h » ('J')