Source/core/dom/DocumentSupplementable.h - Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined.

Side by Side Diff: Source/core/dom/DocumentSupplementable.h

Issue 1060813005: Componentization: fix SupplementTracing<0>::~SupplementTracing<0>(void) already defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)	5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)

6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.	6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.

7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)	7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)

8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)	8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)

9 * Copyright (C) 2013 Google Inc. All rights reserved.	9 * Copyright (C) 2013 Google Inc. All rights reserved.

10 *	10 *

(...skipping 10 matching lines...) Expand all Loading...
21 * You should have received a copy of the GNU Library General Public License	21 * You should have received a copy of the GNU Library General Public License

22 * along with this library; see the file COPYING.LIB. If not, write to	22 * along with this library; see the file COPYING.LIB. If not, write to

23 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,	23 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,

24 * Boston, MA 02110-1301, USA.	24 * Boston, MA 02110-1301, USA.

25 *	25 *

26 */	26 */

27	27

28 #ifndef DocumentSupplementable_h	28 #ifndef DocumentSupplementable_h

29 #define DocumentSupplementable_h	29 #define DocumentSupplementable_h

30	30

	31 #include "core/CoreExport.h"

31 #include "platform/Supplementable.h"	32 #include "platform/Supplementable.h"

	33 #include "platform/heap/Handle.h"

32	34

33 namespace blink {	35 namespace blink {

34	36

35 class Document;	37 class Document;

36	38

	39 extern template class CORE_TEMPLATE_EXPORT WillBeHeapSupplement<Document>;
	tasak 2015/04/22 03:14:48 To fix the following link errors: webcore_shared.d To fix the following link errors: webcore_shared.dll.lib(webcore_shared.dll) : error LNK2005: "public: void __cdecl blink::SupplementableBase<class blink::Document,0>::provideSupplement(char const ,class WTF::PassOwnPtr<class blink::SupplementBase<class blink::Document,0> >)" (?provideSupplement@?$SupplementableBase@VDocument@blink@@$0A@@blink@@QEAAXPEBDV?$PassOwnPtr@V?$SupplementBase@VDocument@blink@@$0A@@blink@@@WTF@@@Z) already defined in modules.DeviceLightDispatcher.obj webcore_shared.dll.lib(webcore_shared.dll) : error LNK2005: "public: class blink::SupplementBase<class blink::Document,0> __cdecl blink::SupplementableBase<class blink::Document,0>::requireSupplement(char const *)" (?requireSupplement@?$SupplementableBase@VDocument@blink@@$0A@@blink@@QEAAPEAV?$SupplementBase@VDocument@blink@@$0A@@2@PEBD@Z) already defined in modules.DeviceLightDispatcher.obj we need this "extern template class".
	40

37 using DocumentSupplementable = WillBeHeapSupplementable<Document>;	41 using DocumentSupplementable = WillBeHeapSupplementable<Document>;

38 using DocumentSupplement = WillBeHeapSupplement<Document>;	42 using DocumentSupplement = WillBeHeapSupplement<Document>;

39	43

40 } // namespace blink	44 } // namespace blink

41	45

42 #endif // DocumentSupplementable_h	46 #endif // DocumentSupplementable_h

OLD	NEW

« Source/core/core.gypi ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/loader/PrerendererClient.h » ('j') | Source/core/page/PageSupplementable.h » ('J')