Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060813003: Set m_FontType in CPDF_Font() constructor. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set m_FontType in CPDF_Font() constructor. This can't change for the life of the object, so tidy up some wild uses throughout the code. Also kill pointless Initialize() method. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/916228365f7f03a51e5fb0e4bab03fa708b107c5

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments, also add |override| to destructors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 1 6 chunks +10 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 8 chunks +6 lines, -22 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, thanks.
5 years, 8 months ago (2015-04-17 19:35:04 UTC) #2
Lei Zhang
https://codereview.chromium.org/1060813003/diff/1/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1060813003/diff/1/core/include/fpdfapi/fpdf_resource.h#newcode256 core/include/fpdfapi/fpdf_resource.h:256: CPDF_Font(int fonttype); explicit, also CPDF_SimpleFont below https://codereview.chromium.org/1060813003/diff/1/core/include/fpdfapi/fpdf_resource.h#newcode309 core/include/fpdfapi/fpdf_resource.h:309: int ...
5 years, 8 months ago (2015-04-17 19:40:59 UTC) #3
Tom Sepez
https://codereview.chromium.org/1060813003/diff/1/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1060813003/diff/1/core/include/fpdfapi/fpdf_resource.h#newcode256 core/include/fpdfapi/fpdf_resource.h:256: CPDF_Font(int fonttype); On 2015/04/17 19:40:59, Lei Zhang wrote: > ...
5 years, 8 months ago (2015-04-17 19:50:26 UTC) #4
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-17 20:00:37 UTC) #5
Tom Sepez
5 years, 8 months ago (2015-04-17 20:07:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
916228365f7f03a51e5fb0e4bab03fa708b107c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698