Update CL description by adding CQ_EXTRA_TRYBOTS for Telemetry changes.

Update CL description by adding CQ_EXTRA_TRYBOTS for Telemetry changes.

This CL adds a post upload hook to add extra try bots list to the CL description in order to run
Telemetry benchmarks on Perf trybots in addtion to CQ trybots if the CL
contains any changes to Telemetry benchmarks.

BUG=462581
Committed: https://crrev.com/3d3ed829fb2e178a0174f518096f553e591a2061
Cr-Commit-Position: refs/heads/master@{#327150}

[prasadv, 2015-04-03 22:26:17]

prasadv@chromium.org changed reviewers:
+ iannucci@chromium.org, simonhatch@chromium.org, sullivan@chromium.org

[prasadv, 2015-04-07 17:07:05]

Friendly ping, PTAL

[prasadv, 2015-04-07 17:07:26]

prasadv@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2015-04-07 17:55:53]

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py
File tools/perf/PRESUBMIT.py (right):

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:110: benchmarks_modified = True
[Optional] The above block could be extracted to a function:

def _BenchmarksModified(change):
  for affected_file in change.AffectedFiles():
    affected_file_path = affected_file.LocalPath()
    file_path, _ = os.path.splitext(affected_file_path)
      if (os.path.join('tools', 'perf', 'benchmarks') in file_path or
          os.path.join('tools', 'perf', 'measurements') in file_path):
      return True
  return False

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:114: r'^CQ_EXTRA_TRYBOYS=.*', original_description, re.M
| re.I):
TRYBOYS -> TRYBOTS

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:114: r'^CQ_EXTRA_TRYBOYS=.*', original_description, re.M
| re.I):
[Optional] If you want to avoid having a long if statement body, you could first
check if you *don't* want to make any changes, and return early:

if not benchmarks_modified or re.search(
    r'^CQ_EXTRA_TRYBOYS=.*', original_description, re.M | re.I):
  return []

# ... update description and add PresubmitNotifyResult ...
return results

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:124: description += '\nCQ_EXTRA_TRYBOYS=%s' %
bots_string
TRYBOYS -> TRYBOTS

[prasadv, 2015-04-08 00:00:16]

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py
File tools/perf/PRESUBMIT.py (right):

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:110: benchmarks_modified = True
On 2015/04/07 17:55:53, qyearsley wrote:
> [Optional] The above block could be extracted to a function:
> 
> def _BenchmarksModified(change):
>   for affected_file in change.AffectedFiles():
>     affected_file_path = affected_file.LocalPath()
>     file_path, _ = os.path.splitext(affected_file_path)
>       if (os.path.join('tools', 'perf', 'benchmarks') in file_path or
>           os.path.join('tools', 'perf', 'measurements') in file_path):
>       return True
>   return False

Done.

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:114: r'^CQ_EXTRA_TRYBOYS=.*', original_description, re.M
| re.I):
On 2015/04/07 17:55:53, qyearsley wrote:
> TRYBOYS -> TRYBOTS

Done.

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:114: r'^CQ_EXTRA_TRYBOYS=.*', original_description, re.M
| re.I):
On 2015/04/07 17:55:53, qyearsley wrote:
> [Optional] If you want to avoid having a long if statement body, you could
first
> check if you *don't* want to make any changes, and return early:
> 
> if not benchmarks_modified or re.search(
>     r'^CQ_EXTRA_TRYBOYS=.*', original_description, re.M | re.I):
>   return []
> 
> # ... update description and add PresubmitNotifyResult ...
> return results

Done.

https://codereview.chromium.org/1060763002/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:124: description += '\nCQ_EXTRA_TRYBOYS=%s' %
bots_string
On 2015/04/07 17:55:53, qyearsley wrote:
> TRYBOYS -> TRYBOTS

Done.

[qyearsley, 2015-04-08 00:07:13]

LGTM

https://codereview.chromium.org/1060763002/diff/20001/tools/perf/PRESUBMIT.py
File tools/perf/PRESUBMIT.py (right):

https://codereview.chromium.org/1060763002/diff/20001/tools/perf/PRESUBMIT.py...
tools/perf/PRESUBMIT.py:91: def _IsBenchmarksModified(change_list):
Should the argument be called change or change_list? It's called change below.

[prasadv, 2015-04-08 00:15:50]

https://codereview.chromium.org/1060763002/diff/20001/tools/perf/PRESUBMIT.py
File tools/perf/PRESUBMIT.py (right):

https://codereview.chromium.org/1060763002/diff/20001/tools/perf/PRESUBMIT.py...
tools/perf/PRESUBMIT.py:91: def _IsBenchmarksModified(change_list):
On 2015/04/08 00:07:13, qyearsley wrote:
> Should the argument be called change or change_list? It's called change below.

Done.

[prasadv, 2015-04-08 18:30:24]

Hi Simon and Robbie, Can you please take a look at this CL.
Thanks

[shatch, 2015-04-08 18:41:48]

On 2015/04/08 18:30:24, prasadv wrote:
> Hi Simon and Robbie, Can you please take a look at this CL.
> Thanks

lgtm

[iannucci, 2015-04-08 19:04:58]

Why don't we always trigger the bots and have them early-exit with analyze.py?
that's how all of the rest of the bots work.....

[prasadv, 2015-04-14 18:04:21]

prasadv@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2015-04-14 18:05:33]

LGTM

[prasadv, 2015-04-24 16:45:59]

The CQ bit was checked by prasadv@chromium.org

[prasadv, 2015-04-24 16:45:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org, simonhatch@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1060763002/#ps60001
(title: "rebasing")

[commit-bot: I haz the power, 2015-04-24 16:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060763002/60001

[commit-bot: I haz the power, 2015-04-24 16:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 16:56:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[prasadv, 2015-04-27 03:51:14]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2015-04-27 03:51:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060763002/60001

[commit-bot: I haz the power, 2015-04-27 04:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 04:01:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shatch, 2015-04-27 15:20:08]

On 2015/04/27 04:01:06, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I think this is missing an owner for codereview.settings.

[iannucci, 2015-04-27 16:44:34]

On 2015/04/27 15:20:08, shatch wrote:
> On 2015/04/27 04:01:06, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> I think this is missing an owner for codereview.settings.

Rs-lgtm

[prasadv, 2015-04-27 16:46:49]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2015-04-27 16:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060763002/60001

[commit-bot: I haz the power, 2015-04-27 16:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 16:57:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[prasadv, 2015-04-27 18:17:30]

prasadv@chromium.org changed reviewers:
+ jam@chromium.org

[prasadv, 2015-04-27 18:17:30]

+jam, for owner approval.

[jam, 2015-04-27 21:37:54]

lgtm

[prasadv, 2015-04-27 21:47:20]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2015-04-27 21:48:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060763002/60001

[commit-bot: I haz the power, 2015-04-27 21:54:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-27 21:55:18]

Patchset 4 (id:??) landed as
https://crrev.com/3d3ed829fb2e178a0174f518096f553e591a2061
Cr-Commit-Position: refs/heads/master@{#327150}