Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2490)

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 1060743003: Cleanup chrome/browser/metrics url constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved to variations dir, improved namespace Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.cc
diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc
index a359f5c10f497ff47a53f68f42472e305e4b6d87..6fbfa5077cde46d472ea3f636db61ce148b8b0de 100644
--- a/chrome/browser/metrics/variations/variations_service.cc
+++ b/chrome/browser/metrics/variations/variations_service.cc
@@ -18,6 +18,7 @@
#include "base/version.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/metrics/variations/generated_resources_map.h"
+#include "chrome/browser/metrics/variations/url_constants.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/metrics/metrics_state_manager.h"
@@ -52,9 +53,6 @@ namespace chrome_variations {
namespace {
-// Default server of Variations seed info.
-const char kDefaultVariationsServerURL[] =
- "https://clients4.google.com/chrome-variations/seed";
const int kMaxRetrySeedFetch = 5;
// TODO(mad): To be removed when we stop updating the NetworkTimeTracker.
@@ -383,7 +381,7 @@ GURL VariationsService::GetVariationsServerURL(
base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kVariationsServerURL));
if (server_url_string.empty())
- server_url_string = kDefaultVariationsServerURL;
+ server_url_string = kDefaultServerUrl;
GURL server_url = GURL(server_url_string);
const std::string restrict_param = !restrict_mode_override.empty() ?
@@ -403,7 +401,7 @@ GURL VariationsService::GetVariationsServerURL(
// static
std::string VariationsService::GetDefaultVariationsServerURLForTesting() {
- return kDefaultVariationsServerURL;
+ return kDefaultServerUrl;
}
// static

Powered by Google App Engine
This is Rietveld 408576698