Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/chromeos/launcher_search_provider/service.cc

Issue 1060733003: Support custom icon in search result. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/launcher_search_provider/service.cc
diff --git a/chrome/browser/chromeos/launcher_search_provider/service.cc b/chrome/browser/chromeos/launcher_search_provider/service.cc
index 47b64355fbb33a3060ee69b25740b81f88ae8806..8ad4a6e47557176e5b9fd08b357bdcb9d2162154 100644
--- a/chrome/browser/chromeos/launcher_search_provider/service.cc
+++ b/chrome/browser/chromeos/launcher_search_provider/service.cc
@@ -99,6 +99,7 @@ void Service::OnOpenResult(const ExtensionId& extension_id,
void Service::SetSearchResults(
const extensions::Extension* extension,
+ scoped_ptr<ErrorReporter> error_reporter,
const std::string& query_id,
const std::vector<linked_ptr<
extensions::api::launcher_search_provider::SearchResult>>& results) {
@@ -122,7 +123,8 @@ void Service::SetSearchResults(
app_list::LauncherSearchResult* search_result =
new app_list::LauncherSearchResult(result->item_id, icon_url, relevance,
- profile_, extension);
+ profile_, extension,
+ error_reporter->Duplicate());
search_result->set_title(base::UTF8ToUTF16(result->title));
search_results.push_back(search_result);
}
@@ -134,6 +136,7 @@ bool Service::IsQueryRunning() const {
}
std::set<ExtensionId> Service::GetListenerExtensionIds() {
+ // TODO(yawano): Cache this result for optimization (crbug.com/440649).
std::set<ExtensionId> extension_ids;
const ExtensionSet& extension_set = extension_registry_->enabled_extensions();

Powered by Google App Engine
This is Rietveld 408576698