Support custom icon in search result.

chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc

Index: chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
diff --git a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc b/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
index bab31505696f20d6ebec2028fdc7b1605770988c..7af4b3cb54ab44365c9cd7249685fa26c2302446 100644
--- a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
+++ b/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
@@ -6,9 +6,7 @@
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/launcher_search_provider/service.h"
-#include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/ui/app_list/search/search_util.h"
-#include "extensions/common/manifest_handlers/icons_handler.h"
 
 using chromeos::launcher_search_provider::Service;
 
@@ -34,25 +32,20 @@ LauncherSearchResult::LauncherSearchResult(
   DCHECK_LE(discrete_value_relevance,
             chromeos::launcher_search_provider::kMaxSearchResultScore);
 
-  // TODO(yawano) Decode passed icon url and show it badged with extension
-  // icon.
-  extension_icon_image_.reset(new extensions::IconImage(
-      profile, extension, extensions::IconsInfo::GetIcons(extension),
-      GetPreferredIconDimension(), extensions::util::GetDefaultExtensionIcon(),
-      nullptr));
+  icon_image_.reset(new ExtensionBadgedIconImage(icon_url, profile, extension,
+                                                 GetPreferredIconDimension()));
 
   Initialize();
 }
 
 LauncherSearchResult::~LauncherSearchResult() {
-  if (extension_icon_image_ != nullptr)
-    extension_icon_image_->RemoveObserver(this);
+  if (icon_image_ != nullptr)
+    icon_image_->RemoveObserver(this);
 }
 
 scoped_ptr<SearchResult> LauncherSearchResult::Duplicate() const {
-  LauncherSearchResult* duplicated_result =
-      new LauncherSearchResult(item_id_, discrete_value_relevance_, profile_,
-                               extension_, extension_icon_image_);
+  LauncherSearchResult* duplicated_result = new LauncherSearchResult(
+      item_id_, discrete_value_relevance_, profile_, extension_, icon_image_);
   duplicated_result->set_title(title());
   return make_scoped_ptr(duplicated_result);
 }
@@ -64,9 +57,9 @@ void LauncherSearchResult::Open(int event_flags) {
   service->OnOpenResult(extension_->id(), item_id_);
 }
 
-void LauncherSearchResult::OnExtensionIconImageChanged(
-    extensions::IconImage* image) {
-  DCHECK_EQ(image, extension_icon_image_.get());
+void LauncherSearchResult::OnIconImageChanged(
+    ExtensionBadgedIconImage* icon_image) {

[Matt Giuca, 2015/04/22 03:31:38]

Don't rename this to icon_image. Keeping it as image makes the DCHECK less
confusing.

[yawano, 2015/04/22 12:23:47]

Done.

+  DCHECK_EQ(icon_image, icon_image_.get());
   UpdateIcon();
 }
 
@@ -75,13 +68,13 @@ LauncherSearchResult::LauncherSearchResult(
     const int discrete_value_relevance,
     Profile* profile,
     const extensions::Extension* extension,
-    const linked_ptr<extensions::IconImage>& extension_icon_image)
+    const linked_ptr<ExtensionBadgedIconImage>& icon_image)
     : item_id_(item_id),
       discrete_value_relevance_(discrete_value_relevance),
       profile_(profile),
       extension_(extension),
-      extension_icon_image_(extension_icon_image) {
-  DCHECK(extension_icon_image_ != nullptr);
+      icon_image_(icon_image) {
+  DCHECK(icon_image_ != nullptr);
   Initialize();
 }
 
@@ -92,13 +85,13 @@ void LauncherSearchResult::Initialize() {
                     chromeos::launcher_search_provider::kMaxSearchResultScore));
   set_details(base::UTF8ToUTF16(extension_->name()));
 
-  extension_icon_image_->AddObserver(this);
+  icon_image_->AddObserver(this);
   UpdateIcon();
 }
 
 void LauncherSearchResult::UpdateIcon() {
-  if (!extension_icon_image_->image_skia().isNull())
-    SetIcon(extension_icon_image_->image_skia());
+  if (!icon_image_->GetIconImage().isNull())
+    SetIcon(icon_image_->GetIconImage());
 }
 
 std::string LauncherSearchResult::GetSearchResultId() {