pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart - Issue 1060713005: rename completion computer to contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

Issue 1060713005: rename completion computer to contributor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/completion_manager.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

index 17127f7eb9e6e5cc720fd146a7b1b51f3e2f3d31..e7f3600e1975166f992e926fb11f6ebd3cc95cbe 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

@@ -127,7 +127,7 @@ class DartCompletionCache extends CompletionCache {

assert(unit.element.source == source);

// Exclude elements from local library

- // because they are provided by LocalComputer

+ // because they are provided by LocalReferenceContributor

Set<LibraryElement> excludedLibs = new Set<LibraryElement>();

excludedLibs.add(unit.element.enclosingElement);

@@ -237,7 +237,7 @@ class DartCompletionCache extends CompletionCache {

});

} else {

// Exclude elements from prefixed imports

- // because they are provided by InvocationComputer

+ // because they are provided by PrefixedElementContributor

_addLibraryPrefixSuggestion(importElem);

excludedLibs.add(importElem.importedLibrary);

}