Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1060703003: Revert of remove unused (by clients) SkPathUtils (Closed)

Created:
5 years, 8 months ago by jcgregorio
Modified:
5 years, 8 months ago
Reviewers:
scroggo, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of https://codereview.chromium.org/1088383003/) Reason for revert: This change is causing the DEPS roll to fail: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/78771/steps/gn/logs/stdio Original issue's description: > remove unused (by clients) SkPathUtils > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7 TBR=scroggo@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/bdb0bf5f8858043878d8a4fa8130c6c87bef3fd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -0 lines) Patch
A bench/PathUtilsBench.cpp View 1 chunk +72 lines, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/utils/SkPathUtils.h View 1 chunk +40 lines, -0 lines 0 comments Download
A samplecode/SamplePathUtils.cpp View 1 chunk +108 lines, -0 lines 0 comments Download
A src/utils/SkPathUtils.cpp View 1 chunk +152 lines, -0 lines 0 comments Download
A tests/PathUtilsTest.cpp View 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jcgregorio
Created Revert of remove unused (by clients) SkPathUtils
5 years, 8 months ago (2015-04-16 16:47:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060703003/1
5 years, 8 months ago (2015-04-16 16:47:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/bdb0bf5f8858043878d8a4fa8130c6c87bef3fd4
5 years, 8 months ago (2015-04-16 16:47:40 UTC) #3
reed2
5 years, 8 months ago (2015-04-17 03:10:31 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1091963002/ by reed@chromium.org.

The reason for reverting is: fix (removal from gypi/gn files) has landed in
chrome..

Powered by Google App Engine
This is Rietveld 408576698