Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: media/audio/win/audio_low_latency_output_win.cc

Issue 1060673002: Disable low latency audio under remote desktop sessions. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable for remote audio, on Open() too. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/win/core_audio_util_win.h » ('j') | media/audio/win/core_audio_util_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/audio_low_latency_output_win.cc
diff --git a/media/audio/win/audio_low_latency_output_win.cc b/media/audio/win/audio_low_latency_output_win.cc
index f7b31a3c00a09d75376a190fa9df926f9b32b6db..53b8a8dd242b0a13de3d1bfc9fa2def74b9ac210 100644
--- a/media/audio/win/audio_low_latency_output_win.cc
+++ b/media/audio/win/audio_low_latency_output_win.cc
@@ -135,6 +135,11 @@ bool WASAPIAudioOutputStream::Open() {
DCHECK(!audio_client_.get());
DCHECK(!audio_render_client_.get());
+ // Don't allow WASAPI streams to be created for remote output devices, this
+ // frequently leads to hangs of the audio thread. http://crbug.com/422522.
+ if (CoreAudioUtil::IsRemoteOutputDevice(device_id_))
+ return false;
+
// Will be set to true if we ended up opening the default communications
// device.
bool communications_device = false;
« no previous file with comments | « no previous file | media/audio/win/core_audio_util_win.h » ('j') | media/audio/win/core_audio_util_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698