Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: media/audio/win/core_audio_util_win.cc

Issue 1060673002: Disable low latency audio under remote desktop sessions. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/core_audio_util_win.cc
diff --git a/media/audio/win/core_audio_util_win.cc b/media/audio/win/core_audio_util_win.cc
index b56d6e6a6e13f9ef749ec4ac57c5e5111c102164..5c6bc7426da8b177a285ffce6b93bcac7ac5911e 100644
--- a/media/audio/win/core_audio_util_win.cc
+++ b/media/audio/win/core_audio_util_win.cc
@@ -170,6 +170,17 @@ bool CoreAudioUtil::IsSupported() {
if (base::win::GetVersion() < base::win::VERSION_VISTA)
return false;
+ // Don't use CoreAudio when a remote desktop session is present; several users
+ // report only WaveAudio working for them and crash reports show hangs when
+ // calling into the OS for CoreAudio API calls. See http://crbug.com/422522
+ // and http://crbug.com/180591.
+ //
+ // Note: It's possible that a user will connect a remote desktop session after
+ // this check has been done. In practice this shouldn't be the dominant case
+ // though and CoreAudio does work for many users.
+ if (GetSystemMetrics(SM_REMOTESESSION))
henrika (OOO until Aug 14) 2015/04/05 14:41:08 This is the only detection method I could find as
+ return false;
+
// The audio core APIs are implemented in the Mmdevapi.dll and Audioses.dll
// system components.
// Dependency Walker shows that it is enough to verify possibility to load
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698