Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1060623002: Adds support for dynamically setting the title (Closed)

Created:
5 years, 8 months ago by cjhopman
Modified:
5 years, 8 months ago
Reviewers:
mdjones, kuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds support for dynamically setting the title Adds a colored title area. When the title is set, it will be exposed with a simple animation. Including the title in the original html is still supported. Fixes some issues with margins and line spacing. Committed: https://crrev.com/dfa26626d7ffc17eba0942e60a1ce8818f8aaa42 Cr-Commit-Position: refs/heads/master@{#324340}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -8 lines) Patch
M components/dom_distiller/core/css/distilledpage.css View 1 4 chunks +37 lines, -6 lines 0 comments Download
M components/dom_distiller/core/html/dom_distiller_viewer.html View 1 1 chunk +8 lines, -2 lines 0 comments Download
M components/dom_distiller/core/javascript/dom_distiller_viewer.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
cjhopman
mdjones: *
5 years, 8 months ago (2015-04-03 18:03:11 UTC) #2
mdjones
lgtm
5 years, 8 months ago (2015-04-03 22:02:41 UTC) #3
mdjones
https://codereview.chromium.org/1060623002/diff/1/components/dom_distiller/core/javascript/dom_distiller_viewer.js File components/dom_distiller/core/javascript/dom_distiller_viewer.js (right): https://codereview.chromium.org/1060623002/diff/1/components/dom_distiller/core/javascript/dom_distiller_viewer.js#newcode28 components/dom_distiller/core/javascript/dom_distiller_viewer.js:28: collapse.style.transition = "height 0.2s"; Note that "transition" is not ...
5 years, 8 months ago (2015-04-03 22:35:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060623002/1
5 years, 8 months ago (2015-04-03 23:08:43 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-03 23:08:45 UTC) #8
cjhopman
kuan@ for committers review
5 years, 8 months ago (2015-04-06 20:29:09 UTC) #10
kuan
lgtm.
5 years, 8 months ago (2015-04-06 22:23:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060623002/1
5 years, 8 months ago (2015-04-07 02:10:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/12284) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-07 02:14:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060623002/20001
5 years, 8 months ago (2015-04-08 23:29:23 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 02:15:03 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 02:15:55 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfa26626d7ffc17eba0942e60a1ce8818f8aaa42
Cr-Commit-Position: refs/heads/master@{#324340}

Powered by Google App Engine
This is Rietveld 408576698