Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4465)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.h

Issue 1060613004: Fix a variety of omnibox bugs around zerosuggest, the escape key, or both. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment fixes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_edit_model.h
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.h b/chrome/browser/ui/omnibox/omnibox_edit_model.h
index e9535bb01571096b5e69e067eded0def5905fdc5..274fca10bbde9428e33f70ff4b23efad38a723aa 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.h
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.h
@@ -275,6 +275,11 @@ class OmniboxEditModel {
// Called when the view is losing focus. Resets some state.
void OnKillFocus();
+ // Returns whether the omnibox will handle a press of the escape key. The
+ // caller can use this to decide whether the browser should process escape as
+ // "stop current page load".
+ bool WillHandleEscapeKey() const;
+
// Called when the user presses the escape key. Decides what, if anything, to
// revert about any current edits. Returns whether the key was handled.
bool OnEscapeKeyPressed();
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698