Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1060603003: SkPDF Metafile: fix recording canvas scaling (Closed)

Created:
5 years, 8 months ago by hal.canary
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SkPDF Metafile: fix recording canvas scaling Scale the recording canvas's page size, not it's canvas matrix. This allows getTotalMatrix() to return the identity matrix. BUG=469656 Committed: https://crrev.com/5baa8fb45970fbc343e130c8d14ba528b3dd934a Cr-Commit-Position: refs/heads/master@{#323820}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M printing/pdf_metafile_skia.cc View 3 chunks +16 lines, -10 lines 1 comment Download

Messages

Total messages: 14 (4 generated)
hal.canary
5 years, 8 months ago (2015-04-03 19:33:28 UTC) #2
f(malita)
lgtm
5 years, 8 months ago (2015-04-03 19:35:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060603003/1
5 years, 8 months ago (2015-04-03 19:35:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54107)
5 years, 8 months ago (2015-04-03 19:46:42 UTC) #7
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/1060603003/diff/1/printing/pdf_metafile_skia.cc File printing/pdf_metafile_skia.cc (right): https://codereview.chromium.org/1060603003/diff/1/printing/pdf_metafile_skia.cc#newcode99 printing/pdf_metafile_skia.cc:99: DCHECK_GT(scale_factor, 0.0f); DCHECK is unnecessary crash on divided ...
5 years, 8 months ago (2015-04-03 20:51:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060603003/1
5 years, 8 months ago (2015-04-03 20:55:27 UTC) #10
hal.canary
On 2015/04/03 20:51:39, Vitaly Buka wrote: > lgtm > > https://codereview.chromium.org/1060603003/diff/1/printing/pdf_metafile_skia.cc > File printing/pdf_metafile_skia.cc (right): ...
5 years, 8 months ago (2015-04-03 20:58:02 UTC) #11
Vitaly Buka (NO REVIEWS)
On 2015/04/03 20:58:02, Hal Canary wrote: > On 2015/04/03 20:51:39, Vitaly Buka wrote: > > ...
5 years, 8 months ago (2015-04-03 21:00:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 21:39:54 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 21:40:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5baa8fb45970fbc343e130c8d14ba528b3dd934a
Cr-Commit-Position: refs/heads/master@{#323820}

Powered by Google App Engine
This is Rietveld 408576698