bluetooth: connectGATT and receive WebBluetoothGATTRemoteServer from embedder.

bluetooth: connectGATT and receive WebBluetoothGATTRemoteServer from embedder.

Initial implementation of connectGATT. Next steps is to actually connect to the device.

Third of a set of 3 patches to implement connectGATT.

  [1] https://codereview.chromium.org/1093633003
  [2] https://codereview.chromium.org/1082273006
  [3] This patch.


BUG=421668, 476735
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194169

[ortuno, 2015-04-17 02:13:35]

Patchset #1 (id:1) has been deleted

[ortuno, 2015-04-20 20:48:41]

Patchset #1 (id:20001) has been deleted

[ortuno, 2015-04-20 20:49:58]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-04-20 20:49:59]

Please review @scheib

[scheib, 2015-04-21 17:57:29]

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
File Source/modules/bluetooth/BluetoothDevice.h (right):

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
Source/modules/bluetooth/BluetoothDevice.h:17: 
remove blank line, sort block.

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp (right):

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp:18:
BluetoothGATTRemoteServer* BluetoothGATTRemoteServer::create(const
WebBluetoothGATTRemoteServer& webGATT)
You're patterning after my code, and so this is my fault, but we don't need the
::create function here, just the constructor will do. Typically a ::create will
be used if there are e.g. errors that can happen that need to be handled (can't
return from a constructor and decide to not produce an object). Or, when
additional work must be done after an object is constructed.

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right):

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
Source/modules/bluetooth/BluetoothGATTRemoteServer.h:23: : public
GarbageCollectedFinalized<BluetoothGATTRemoteServer>
I don't think we need this object to be Finalized, or did I miss something?

[ortuno, 2015-04-21 19:54:07]

@scheib: ready for review again

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
File Source/modules/bluetooth/BluetoothDevice.h (right):

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
Source/modules/bluetooth/BluetoothDevice.h:17: 
On 2015/04/21 at 17:57:29, scheib wrote:
> remove blank line, sort block.

Done.

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp (right):

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp:18:
BluetoothGATTRemoteServer* BluetoothGATTRemoteServer::create(const
WebBluetoothGATTRemoteServer& webGATT)
On 2015/04/21 at 17:57:29, scheib wrote:
> You're patterning after my code, and so this is my fault, but we don't need
the ::create function here, just the constructor will do. Typically a ::create
will be used if there are e.g. errors that can happen that need to be handled
(can't return from a constructor and decide to not produce an object). Or, when
additional work must be done after an object is constructed.

Done.

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right):

https://codereview.chromium.org/1060593004/diff/40001/Source/modules/bluetoot...
Source/modules/bluetooth/BluetoothGATTRemoteServer.h:23: : public
GarbageCollectedFinalized<BluetoothGATTRemoteServer>
On 2015/04/21 at 17:57:29, scheib wrote:
> I don't think we need this object to be Finalized, or did I miss something?

WebBluetoothGATTRemoteServer needs to be finalized so this object also needs to
be finalized.

[scheib, 2015-04-21 20:04:20]

LGTM

[ortuno, 2015-04-21 20:15:44]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-21 20:15:44]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1060593004/#ps80001
(title: "Merged with origin/master")

[commit-bot: I haz the power, 2015-04-21 20:15:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060593004/80001

[ortuno, 2015-04-21 21:25:03]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-04-21 21:25:04]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1060593004/#ps100001
(title: "Web Exposed test changed")

[commit-bot: I haz the power, 2015-04-21 21:25:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060593004/100001

[commit-bot: I haz the power, 2015-04-21 22:36:16]

Committed patchset #4 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194169