Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1060583008: Port CallSite methods to C++. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port CallSite methods to C++. The goal is to port all of error stack trace formatting to C++. We will do this bottom up, by first porting helper functions. Eventually, CallSite methods will only be used when a custom error stack trace formatter is defined via Error.prepareStackTrace. R=jkummerow@chromium.org Committed: https://crrev.com/4d12e9480133a2e4d65749c5c2587ec685bb5c76 Cr-Commit-Position: refs/heads/master@{#28095}

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comments and rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -88 lines) Patch
M src/messages.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/messages.cc View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M src/messages.js View 1 2 3 chunks +40 lines, -51 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +34 lines, -27 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/regress-stacktrace.js View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Yang
5 years, 8 months ago (2015-04-24 13:01:54 UTC) #1
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1060583008/diff/1/src/messages.h File src/messages.h (right): https://codereview.chromium.org/1060583008/diff/1/src/messages.h#newcode99 src/messages.h:99: int GetLineNumber(Isolate* isolate); To prevent future ...
5 years, 8 months ago (2015-04-27 12:18:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060583008/40001
5 years, 8 months ago (2015-04-28 08:28:22 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-28 08:53:16 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 08:53:32 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d12e9480133a2e4d65749c5c2587ec685bb5c76
Cr-Commit-Position: refs/heads/master@{#28095}

Powered by Google App Engine
This is Rietveld 408576698