Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1060583007: reduce alloc overhead for SkCanvas (Closed)

Created:
5 years, 8 months ago by reed2
Modified:
5 years, 8 months ago
Reviewers:
reed, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

reduce alloc overhead for SkCanvas use pre-allocated space in the canvas to avoid initial calls to malloc BUG=skia: Committed: https://skia.googlesource.com/skia/+/b679ca8926a832274b14fdb512f88f64b61d32ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M include/core/SkCanvas.h View 2 chunks +9 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 13 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060583007/1
5 years, 8 months ago (2015-04-07 03:33:24 UTC) #2
reed2
just one more left to eliminate, the device itself
5 years, 8 months ago (2015-04-07 03:34:33 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-07 03:39:35 UTC) #6
mtklein
Before: 26M 1 2.25µs 2.4µs 2.58µs 8.4µs 37% █▂▁▁▁▁▁▂▂▁▁▁▁▂▁▁▁▁▁▁▁▁▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁ nonrendering picture_overhead_draw 13M 23 1.19µs 1.38µs ...
5 years, 8 months ago (2015-04-07 11:37:22 UTC) #7
mtklein
lgtm
5 years, 8 months ago (2015-04-07 11:38:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060583007/1
5 years, 8 months ago (2015-04-07 11:40:43 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 11:40:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b679ca8926a832274b14fdb512f88f64b61d32ea

Powered by Google App Engine
This is Rietveld 408576698