WebGL backbuffer creation on Mali-400 GPU

Source/core/html/canvas/WebGLRenderingContextBase.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1432 matching lines @@
     if (isContextLost())
         return;
     m_clearStencil = s;
     webContext()->clearStencil(s);
 }
 
 void WebGLRenderingContextBase::colorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha)
 {
     if (isContextLost())
         return;
+    // Disable alpha writes, if requested alpha attribute is false & backbuffer allocated as GL_RGBA
+    if (!m_requestedAttributes.alpha() && !drawingBuffer()->isRGBTextureSupported())
+        alpha = '\0';

[Ken Russell (switch to Gerrit), 2015/04/06 21:43:18]

That's a strange way to write that constant. Please use alpha = false or
GL_FALSE.

     m_colorMask[0] = red;
     m_colorMask[1] = green;
     m_colorMask[2] = blue;
     m_colorMask[3] = alpha;
     webContext()->colorMask(red, green, blue, alpha);
 }
 
 void WebGLRenderingContextBase::compileShader(WebGLShader* shader)
 {
     if (isContextLost() || !validateWebGLObject("compileShader", shader))
@@ skipping 872 matching lines @@
         return ScriptValue::createNull(scriptState);
     const int intZero = 0;
     switch (pname) {
     case GL_ACTIVE_TEXTURE:
         return getUnsignedIntParameter(scriptState, pname);
     case GL_ALIASED_LINE_WIDTH_RANGE:
         return getWebGLFloatArrayParameter(scriptState, pname);
     case GL_ALIASED_POINT_SIZE_RANGE:
         return getWebGLFloatArrayParameter(scriptState, pname);
     case GL_ALPHA_BITS:
-        return getIntParameter(scriptState, pname);
+        // Report 0 bits, if requested alpha attribute is false & backbuffer allocated as GL_RGBA
+        return (!m_requestedAttributes.alpha() && !drawingBuffer()->isRGBTextureSupported()) > 0

[Ken Russell (switch to Gerrit), 2015/04/06 21:43:18]

This is a strange way to write a boolean test. Please drop the "> 0".

+            ? WebGLAny(scriptState, intZero)
+            : getIntParameter(scriptState, pname);

[Ken Russell (switch to Gerrit), 2015/04/06 21:43:18]

Please also fix up the query of COLOR_WRITEMASK.

     case GL_ARRAY_BUFFER_BINDING:
         return WebGLAny(scriptState, PassRefPtrWillBeRawPtr<WebGLObject>(m_boundArrayBuffer.get()));
     case GL_BLEND:
         return getBooleanParameter(scriptState, pname);
     case GL_BLEND_COLOR:
         return getWebGLFloatArrayParameter(scriptState, pname);
     case GL_BLEND_DST_ALPHA:
         return getUnsignedIntParameter(scriptState, pname);
     case GL_BLEND_DST_RGB:
         return getUnsignedIntParameter(scriptState, pname);
@@ skipping 3669 matching lines @@
     return m_sharedWebGraphicsContext3D ? m_sharedWebGraphicsContext3D->drawingBuffer() : 0;
 }
 #else
 DrawingBuffer* WebGLRenderingContextBase::drawingBuffer() const
 {
     return m_drawingBuffer.get();
 }
 #endif
 
 } // namespace blink